Skip to content

Commit c4bac37

Browse files
committed
C#: Fix UncheckedCastInEquals.
1 parent 1758a5e commit c4bac37

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

csharp/ql/src/Likely Bugs/UncheckedCastInEquals.ql

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,12 @@
1313
import csharp
1414
import semmle.code.csharp.frameworks.System
1515

16-
private predicate equalsMethodChild(EqualsMethod equals, Element child) {
17-
child = equals
18-
or
19-
equalsMethodChild(equals, child.getParent())
20-
}
21-
2216
predicate nodeBeforeParameterAccess(ControlFlowNode node) {
2317
exists(EqualsMethod equals | equals.getBody().getControlFlowNode() = node)
2418
or
2519
exists(EqualsMethod equals, Parameter param, ControlFlowNode mid |
2620
equals.getParameter(0) = param and
27-
equalsMethodChild(equals, any(ControlFlowElement e | e.getControlFlowNode() = mid)) and
21+
equals = mid.getEnclosingCallable() and
2822
nodeBeforeParameterAccess(mid) and
2923
not param.getAnAccess().getControlFlowNode() = mid and
3024
mid.getASuccessor() = node

0 commit comments

Comments
 (0)