Skip to content

Commit cda88a5

Browse files
committed
Python: Refactor: use DataFlow::Node.asExpr()
1 parent ddc55a1 commit cda88a5

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

python/ql/src/experimental/dataflow/internal/TaintTrackingPrivate.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ predicate stringManipulation(DataFlow::CfgNode nodeFrom, DataFlow::CfgNode nodeT
128128
)
129129
or
130130
// f-strings
131-
nodeTo.getNode().getNode().(Fstring).getAValue() = nodeFrom.getNode().getNode()
131+
nodeTo.asExpr().(Fstring).getAValue() = nodeFrom.asExpr()
132132
// TODO: Handle encode/decode from base64/quopri
133133
// TODO: Handle os.path.join
134134
// TODO: Handle functions in https://docs.python.org/3/library/binascii.html
@@ -210,7 +210,7 @@ predicate forStep(DataFlow::CfgNode nodeFrom, DataFlow::EssaNode nodeTo) {
210210
exists(EssaNodeDefinition defn, For for |
211211
for.getTarget().getAChildNode*() = defn.getDefiningNode().getNode() and
212212
nodeTo.getVar() = defn and
213-
nodeFrom.getNode().getNode() = for.getIter()
213+
nodeFrom.asExpr() = for.getIter()
214214
)
215215
}
216216

@@ -223,6 +223,6 @@ predicate unpackingAssignmentStep(DataFlow::CfgNode nodeFrom, DataFlow::EssaNode
223223
exists(MultiAssignmentDefinition defn, Assign assign |
224224
assign.getATarget().contains(defn.getDefiningNode().getNode()) and
225225
nodeTo.getVar() = defn and
226-
nodeFrom.getNode().getNode() = assign.getValue()
226+
nodeFrom.asExpr() = assign.getValue()
227227
)
228228
}

0 commit comments

Comments
 (0)