Fix bug so property accesses can be barrier guards

owen-mc · owen-mc · commit d296a8a8bfdb · 2026-01-09T15:15:06.000Z
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll
@@ -474,7 +474,7 @@ private module Cached {
       kmp = TMkPair(kind, model) and
       gv = convertAcceptingValue(acceptingvalue)
     |
-      g.(Call).getAnArgument() = e or g.(MethodCall).getQualifier() = e
+      g.(Call).getAnArgument() = e or g.(QualifiableExpr).getQualifier() = e
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ private module Cached {`
`474`	`474`	`kmp = TMkPair(kind, model) and`
`475`	`475`	`gv = convertAcceptingValue(acceptingvalue)`
`476`	`476`	`\|`
`477`		`- g.(Call).getAnArgument() = e or g.(MethodCall).getQualifier() = e`
	`477`	`+ g.(Call).getAnArgument() = e or g.(QualifiableExpr).getQualifier() = e`
`478`	`478`	`)`
`479`	`479`	`}`
`480`	`480`