Merge pull request #21627 from michaelnebel/csharp/cleanup

C#: Deprecate get[L|R]Value predicates.

Author: michaelnebel

csharp/ql/lib/Linq/Helpers.qll

@@ -77,7 +77,7 @@ predicate missedAllOpportunity(ForeachStmtGenericEnumerable fes) {
     // The then case of the if assigns false to something and breaks out of the loop.
     exists(Assignment a, BoolLiteral bl |
       a = is.getThen().getAChild*() and
-      bl = a.getRValue() and
+      bl = a.getRightOperand() and
       bl.toString() = "false"
     ) and
     is.getThen().getAChild*() instanceof BreakStmt

csharp/ql/lib/change-notes/2026-04-01-getlrvalue.md

@@ -0,0 +1,4 @@
+---
+category: deprecated
+---
+* The predicates `get[L|R]Value` in the class `Assignment` have been deprecated. Use `get[Left|Right]Operand` instead.

csharp/ql/lib/definitions.qll

@@ -96,7 +96,7 @@ private class MethodUse extends Use, QualifiableExpr {
 private class AccessUse extends Access, Use {
   AccessUse() {
     not this.getTarget().(Parameter).getCallable() instanceof Accessor and
-    not this = any(LocalVariableDeclAndInitExpr d).getLValue() and
+    not this = any(LocalVariableDeclAndInitExpr d).getLeftOperand() and
     not this.isImplicit() and
     not this instanceof MethodAccess and // handled by `MethodUse`
     not this instanceof TypeAccess and // handled by `TypeMentionUse`

csharp/ql/lib/semmle/code/csharp/Assignable.qll

@@ -235,7 +235,7 @@ private class RefArg extends AssignableAccess {
 module AssignableInternal {
   private predicate tupleAssignmentDefinition(AssignExpr ae, Expr leaf) {
     exists(TupleExpr te |
-      ae.getLValue() = te and
+      ae.getLeftOperand() = te and
       te.getAnArgument+() = leaf and
       // `leaf` is either an assignable access or a local variable declaration
       not leaf instanceof TupleExpr
@@ -249,8 +249,8 @@ module AssignableInternal {
    */
   private predicate tupleAssignmentPair(AssignExpr ae, Expr left, Expr right) {
     tupleAssignmentDefinition(ae, _) and
-    left = ae.getLValue() and
-    right = ae.getRValue()
+    left = ae.getLeftOperand() and
+    right = ae.getRightOperand()
     or
     exists(TupleExpr l, TupleExpr r, int i | tupleAssignmentPair(ae, l, r) |
       left = l.getArgument(i) and
@@ -291,7 +291,7 @@ module AssignableInternal {
     cached
     newtype TAssignableDefinition =
       TAssignmentDefinition(Assignment a) {
-        not a.getLValue() instanceof TupleExpr and
+        not a.getLeftOperand() instanceof TupleExpr and
         not a instanceof AssignCallOperation and
         not a instanceof AssignCoalesceExpr
       } or
@@ -358,7 +358,7 @@ module AssignableInternal {
     // Not defined by dispatch in order to avoid too conservative negative recursion error
     cached
     AssignableAccess getTargetAccess(AssignableDefinition def) {
-      def = TAssignmentDefinition(any(Assignment a | a.getLValue() = result))
+      def = TAssignmentDefinition(any(Assignment a | a.getLeftOperand() = result))
       or
       def = TTupleAssignmentDefinition(_, result)
       or
@@ -381,8 +381,8 @@ module AssignableInternal {
         tupleAssignmentPair(ae, ac, result)
       )
       or
-      exists(Assignment ass | ac = ass.getLValue() |
-        result = ass.getRValue() and
+      exists(Assignment ass | ac = ass.getLeftOperand() |
+        result = ass.getRightOperand() and
         not ass instanceof AssignOperation
       )
       or
@@ -527,7 +527,7 @@ module AssignableDefinitions {
     Assignment getAssignment() { result = a }
 
     override Expr getSource() {
-      result = a.getRValue() and
+      result = a.getRightOperand() and
       not a instanceof AddOrRemoveEventExpr
     }
 

csharp/ql/lib/semmle/code/csharp/PrintAst.qll

@@ -343,10 +343,10 @@ final class AssignmentNode extends ControlFlowElementNode {
     result.(TypeMentionNode).getTarget() = controlFlowElement
     or
     childIndex = 0 and
-    result.(ElementNode).getElement() = assignment.getLValue()
+    result.(ElementNode).getElement() = assignment.getLeftOperand()
     or
     childIndex = 1 and
-    result.(ElementNode).getElement() = assignment.getRValue()
+    result.(ElementNode).getElement() = assignment.getRightOperand()
   }
 }
 

csharp/ql/lib/semmle/code/csharp/Property.qll

@@ -535,8 +535,8 @@ class Setter extends Accessor, @setter {
     exists(AssignExpr assign |
       this.getStatementBody().getNumberOfStmts() = 1 and
       assign.getParent() = this.getStatementBody().getAChild() and
-      assign.getLValue() = result.getAnAccess() and
-      assign.getRValue() = accessToValue()
+      assign.getLeftOperand() = result.getAnAccess() and
+      assign.getRightOperand() = accessToValue()
     )
   }
 

csharp/ql/lib/semmle/code/csharp/controlflow/Guards.qll

@@ -136,7 +136,7 @@ private module GuardsInput implements
     IdExpr() { this instanceof AssignExpr or this instanceof CastExpr }
 
     Expr getEqualChildExpr() {
-      result = this.(AssignExpr).getRValue()
+      result = this.(AssignExpr).getRightOperand()
       or
       result = this.(CastExpr).getExpr()
     }
@@ -836,7 +836,7 @@ module Internal {
 
   /** Holds if expression `e2` is a `null` value whenever `e1` is. */
   predicate nullValueImpliedUnary(Expr e1, Expr e2) {
-    e1 = e2.(AssignExpr).getRValue()
+    e1 = e2.(AssignExpr).getRightOperand()
     or
     e1 = e2.(Cast).getExpr()
     or
@@ -923,7 +923,7 @@ module Internal {
   /** Holds if expression `e2` is a non-`null` value whenever `e1` is. */
   predicate nonNullValueImpliedUnary(Expr e1, Expr e2) {
     e1 = e2.(CastExpr).getExpr() or
-    e1 = e2.(AssignExpr).getRValue() or
+    e1 = e2.(AssignExpr).getRightOperand() or
     e1 = e2.(NullCoalescingOperation).getAnOperand()
   }
 

csharp/ql/lib/semmle/code/csharp/controlflow/internal/ControlFlowGraphImpl.qll

@@ -521,7 +521,7 @@ module Expressions {
         // ```
         // need special treatment, because the accesses `[0]`, `[1]`, and `[2]`
         // have no qualifier.
-        this = any(MemberInitializer mi).getLValue()
+        this = any(MemberInitializer mi).getLeftOperand()
       ) and
       not exists(AssignableDefinitions::OutRefDefinition def | def.getTargetAccess() = this)
     }

csharp/ql/lib/semmle/code/csharp/dataflow/Nullness.qll

@@ -31,7 +31,7 @@ private Expr maybeNullExpr(Expr reason) {
   or
   result instanceof AsExpr and reason = result
   or
-  result.(AssignExpr).getRValue() = maybeNullExpr(reason)
+  result.(AssignExpr).getRightOperand() = maybeNullExpr(reason)
   or
   result.(CastExpr).getExpr() = maybeNullExpr(reason)
   or

csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll

@@ -528,7 +528,7 @@ module LocalFlow {
     e2 =
       any(AssignExpr ae |
         ae.getParent() = any(ControlFlowElement cfe | not cfe instanceof ExprStmt) and
-        e1 = ae.getRValue()
+        e1 = ae.getRightOperand()
       )
     or
     e1 = e2.(ObjectCreation).getInitializer()
@@ -554,7 +554,7 @@ module LocalFlow {
       e2 = we
     )
     or
-    exists(AssignExpr ae | ae.getLValue().(TupleExpr) = e2 and ae.getRValue() = e1)
+    exists(AssignExpr ae | ae.getLeftOperand().(TupleExpr) = e2 and ae.getRightOperand() = e1)
     or
     exists(ControlFlowElement cfe | cfe = e2.(TupleExpr).(PatternExpr).getPatternMatch() |
       cfe.(IsExpr).getExpr() = e1
@@ -795,7 +795,7 @@ private predicate fieldOrPropertyStore(ContentSet c, Expr src, Expr q, boolean p
       q = we and
       mi = we.getInitializer().getAMemberInitializer() and
       f = mi.getInitializedMember() and
-      src = mi.getRValue() and
+      src = mi.getRightOperand() and
       postUpdate = false
     )
     or
@@ -804,7 +804,7 @@ private predicate fieldOrPropertyStore(ContentSet c, Expr src, Expr q, boolean p
       mi = q.(ObjectInitializer).getAMemberInitializer() and
       q.getParent() instanceof ObjectCreation and
       f = mi.getInitializedMember() and
-      src = mi.getRValue() and
+      src = mi.getRightOperand() and
       postUpdate = false
     )
     or
@@ -879,8 +879,8 @@ private predicate arrayStore(Expr src, Expr a, boolean postUpdate) {
   // Member initializer, `new C { Array = { [i] = src } }`
   exists(MemberInitializer mi |
     mi = a.(ObjectInitializer).getAMemberInitializer() and
-    mi.getLValue() instanceof ArrayAccess and
-    mi.getRValue() = src and
+    mi.getLeftOperand() instanceof ArrayAccess and
+    mi.getRightOperand() = src and
     postUpdate = false
   )
 }
@@ -2582,7 +2582,7 @@ module PostUpdateNodes {
         call.getExpr() = init.(CollectionInitializer).getAnElementInitializer()
         or
         // E.g. `new Dictionary<int, string>() { [0] = "a", [1] = "b" }`
-        call.getExpr() = init.(ObjectInitializer).getAMemberInitializer().getLValue()
+        call.getExpr() = init.(ObjectInitializer).getAMemberInitializer().getLeftOperand()
       )
     }
 
@@ -2795,7 +2795,7 @@ predicate additionalLambdaFlowStep(Node nodeFrom, Node nodeTo, boolean preserves
   preservesValue = true
   or
   exists(AddEventExpr aee |
-    nodeFrom.asExpr() = aee.getRValue() and
+    nodeFrom.asExpr() = aee.getRightOperand() and
     nodeTo.asExpr().(EventRead).getTarget() = aee.getTarget() and
     preservesValue = false
   )