Go: Use getLocation instead of hasLocationInfo#18883
Merged
owen-mc merged 3 commits intogithub:mainfrom Feb 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This pull request deprecates the member predicate hasLocationInfo and instructs users to use getLocation() instead.
- Introduced deprecation documentation for hasLocationInfo.
Reviewed Changes
| File | Description |
|---|---|
| go/ql/lib/change-notes/2025-02-27-haslocationinfo-deprecated.md | New change note file that documents the deprecation of hasLocationInfo and suggests using getLocation() |
Copilot reviewed 105 out of 105 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
owen-mc
force-pushed
the
go/get-location
branch
from
4e72f26 to
a94854b
Compare
smowton
approved these changes
Feb 27, 2025
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
LGTM. Only reviewed the non-test changes on the assumption that test changes would show up in the results if they were materially wrong.
Contributor
Author
|
DCA summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry this isn't very easy to review. I did consider pulling it into separate commits: "Add
getLocation", "UsegetLocationinstead ofhasLocationInfo", "MakehasLocationInfocallgetLocationand delete overrides", "DeprecatehasLocationInfo". If it really is impossible to review in its current state then I can do that.As a test, I commented out all of the newly-deprecated predicates and ran all the tests, to check we aren't using them anywhere. They all passed.