Set the executable bit on the scripts in the Actions extractor#18888
Merged
Set the executable bit on the scripts in the Actions extractor#18888
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
dbartol
force-pushed
the
dbartol/actions-executable-bit
branch
from
8cbe0d1 to
ac555ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bash script in the
actionsextractor has its executable bit set in the repo, but was losing that bit somewhere along the way from the repo checkout to the CLI zip file. The fix is to specify the scripts in theexesparameter ofcodeql_pkg_filesrather than in thesrcsparameter.We didn't notice this because everywhere we test the Actions extractor, it's being picked up from the repo, not the CLI distribution. It also didn't affect anyone using the CodeQL Action, because the Action had an embedded copy of the
actionsextractor, and that copy does have the executable bit set correctly 🤦♂️.