Rust: Take dependency renaming into account when extracting the crate graph#19057
Merged
hvitved merged 3 commits intogithub:mainfrom Mar 20, 2025
Merged
Rust: Take dependency renaming into account when extracting the crate graph#19057hvitved merged 3 commits intogithub:mainfrom
hvitved merged 3 commits intogithub:mainfrom
Conversation
hvitved
force-pushed
the
rust/dependency-renaming
branch
from
115affc to
538a22a
Compare
hvitved
changed the title
hvitved
force-pushed
the
rust/dependency-renaming
branch
from
538a22a to
0bf2bfa
Compare
hvitved
commented
Mar 19, 2025
Comment on lines
+82
to
+83
| #-----| md5 -> Crate(md5@0.10.6) | ||
| #-----| md5_alt -> Crate(md5@0.7.0) |
Contributor
Author
There was a problem hiding this comment.
Here we see that the renamed md5_alt is picked up.
aibaars
reviewed
Mar 20, 2025
rust/schema/prelude.py
Outdated
| @qltest.skip | ||
| @ql.internal | ||
| class NamedCrate(Element): | ||
| name: optional[string] |
Contributor
There was a problem hiding this comment.
Should we make the name non-optional?
aibaars
previously approved these changes
Mar 20, 2025
Contributor
aibaars
left a comment
aibaars
left a comment
There was a problem hiding this comment.
Looks good to me. Just wondering whether we should make name non-optional. Possibly having a NamedCrate without name feels a bit odd.
aibaars
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts dependency renaming, for example as in