Go: update files generated by depstubber#19076
Merged
owen-mc merged 5 commits intogithub:mainfrom Apr 9, 2025
Merged
Conversation
These were all generated by running depstubber.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates depstubber commands for Go tests to improve stub readability and compatibility with updated Go versions.
- Updated the depstubber command for the ORM package to include the Formatter stub alongside Query.
- Regenerated stubs to reflect improvements in dependency handling.
Comments suppressed due to low confidence (1)
go/ql/test/library-tests/semmle/go/frameworks/SQL/pg.go:4
- [nitpick] The updated depstubber command now includes 'Formatter'. Consider adding a brief inline comment explaining the introduction of Formatter to help future maintainers understand its purpose.
//go:generate depstubber -vendor github.com/go-pg/pg/orm Query,Formatter Q
owen-mc
changed the title
smowton
approved these changes
Apr 9, 2025
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
If the tests remain happy, so do I
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reran depstubber on all the commands we have stored in tests and regenerated the stubs. I did this to test some changes to I made to depstubber, but there were some slight improvements to stubs that I have collected in this PR. This makes some stubs easier to read and updates some
vendor/modules.txtso that they will still work if we update the go version used in the test.