Fix typo in ReusableWorkflowsSinks.ql identifier#19277
Closed
felicitymay wants to merge 1 commit intomainfrom
Closed
Fix typo in ReusableWorkflowsSinks.ql identifier#19277felicitymay wants to merge 1 commit intomainfrom
felicitymay wants to merge 1 commit intomainfrom
Conversation
felicitymay
added
the
no-change-note-required
adityasharad
approved these changes
Apr 10, 2025
Collaborator
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Thanks. This change is safe for default and security-extended suite users.
It would churn things for security-and-quality suite users because we have accidentally include these telemetry queries in that suite. I'll merge and we can add a quick follow up to remove it from that suite; then those alerts (that should never have been shown) will close.
Contributor
Author
|
Closing a very old PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot spotted this when reviewing a PR in the CodeQL docs publication repository.
Will fixing this break anything else, or is safe to correct here?