Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions csharp/ql/test/library-tests/conversion/span/Span.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
using System;
using System.Collections.Generic;

public interface CovariantInterface<out T> { }

public interface InvariantInterface<T> { }

public interface Interface<out T1, T2> { }

public class Base { }

public class Derived : Base { }

public class C
{
public void M()
{
string[] stringArray = [];
string[][] stringArrayArray;
string[,] stringArray2D;

Span<string> stringSpan = stringArray; // string[] -> Span<string>;

// Covariant conversions to ReadOnlySpan
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a test case for something like

ReadOnlySpan<Base> x = // something of type `Derived[]`;
ReadOnlySpan<Base> x = // something of type `Span<Derived>`;

which I'm not sure the current logic is able to handle?

// Assignments are included to illustrate that this compiles.
// Only the use of the types matter in terms of test output.
ReadOnlySpan<CovariantInterface<Base>> covariantInterfaceBaseReadOnlySpan;
ReadOnlySpan<CovariantInterface<Derived>> covariantInterfaceDerivedReadOnlySpan = default;
Span<CovariantInterface<Derived>> covariantInterfaceDerivedSpan = default;
CovariantInterface<Derived>[] covariantInterfaceDerivedArray = [];
covariantInterfaceBaseReadOnlySpan = covariantInterfaceDerivedReadOnlySpan; // ReadOnlySpan<CovariantInterface<Derived>> -> ReadOnlySpan<CovariantInterface<Base>>
covariantInterfaceBaseReadOnlySpan = covariantInterfaceDerivedSpan; // Span<CovariantInterface<Derived>> -> ReadOnlySpan<CovariantInterface<Base>>
covariantInterfaceBaseReadOnlySpan = covariantInterfaceDerivedArray; // CovariantInterface<Derived>[] -> ReadOnlySpan<CovariantInterface<Base>>

// Identify conversions to ReadOnlySpan
ReadOnlySpan<string> stringReadOnlySpan;
stringReadOnlySpan = stringSpan; // Span<string> -> ReadOnlySpan<string>;
stringReadOnlySpan = stringArray; // string[] -> ReadOnlySpan<string>;

// Convert string to ReadOnlySpan<char>
string s = "";
ReadOnlySpan<char> charReadOnlySpan = s; // string -> ReadOnlySpan<char>

// Use the non-covariant interfaces to show that no conversion is possible.
ReadOnlySpan<InvariantInterface<Base>> invariantInterfaceBaseReadOnlySpan;
ReadOnlySpan<InvariantInterface<Derived>> invariantInterfaceDerivedReadOnlySpan;
Span<InvariantInterface<Derived>> invariantInterfaceDerivedSpan;
InvariantInterface<Derived>[] invariantInterfaceDerivedArray;
ReadOnlySpan<Interface<Base, string>> interfaceBaseReadOnlySpan;
ReadOnlySpan<Interface<Derived, string>> interfaceDerivedReadOnlySpan;
Span<Interface<Derived, string>> interfaceDerivedSpan;
Interface<Derived, string>[] interfaceDerivedArray;
}
}
16 changes: 16 additions & 0 deletions csharp/ql/test/library-tests/conversion/span/span.expected
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
| CovariantInterface<Derived>[] | ReadOnlySpan<CovariantInterface<Base>> |
| CovariantInterface<Derived>[] | ReadOnlySpan<CovariantInterface<Derived>> |
| CovariantInterface<Derived>[] | Span<CovariantInterface<Derived>> |
| Interface<Derived,String>[] | ReadOnlySpan<Interface<Derived, string>> |
| Interface<Derived,String>[] | Span<Interface<Derived, string>> |
| InvariantInterface<Derived>[] | ReadOnlySpan<InvariantInterface<Derived>> |
| InvariantInterface<Derived>[] | Span<InvariantInterface<Derived>> |
| ReadOnlySpan<CovariantInterface<Derived>> | ReadOnlySpan<CovariantInterface<Base>> |
| Span<CovariantInterface<Derived>> | ReadOnlySpan<CovariantInterface<Base>> |
| Span<CovariantInterface<Derived>> | ReadOnlySpan<CovariantInterface<Derived>> |
| Span<Interface<Derived, string>> | ReadOnlySpan<Interface<Derived, string>> |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected something like

| Span<Interface<Derived, string>> | ReadOnlySpan<Interface<Base, string>> |

here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, that is a very nice catch! The documentation on variance conversion is a bit sketchy and I mistakenly assumed that all type parameters needed to be declared out. However, as you point out (and this is also accepted by the compiler), identity conversions are also accepted for non-covariant type parameters.
I will improve this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the implicit conversions are allowed for all variance convertible types (and not only covariant convertible types as hinted in the documentation of the feature)

| Span<InvariantInterface<Derived>> | ReadOnlySpan<InvariantInterface<Derived>> |
| Span<string> | ReadOnlySpan<string> |
| String[] | ReadOnlySpan<string> |
| String[] | Span<string> |
| string | ReadOnlySpan<char> |
9 changes: 9 additions & 0 deletions csharp/ql/test/library-tests/conversion/span/span.ql
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import semmle.code.csharp.Conversion

private class InterestingType extends Type {
InterestingType() { exists(LocalVariable lv | lv.getType() = this) }
}

from InterestingType sub, InterestingType sup
where convSpan(sub, sup) and sub != sup
select sub.toStringWithTypes() as s1, sup.toStringWithTypes() as s2 order by s1, s2