-
Notifications
You must be signed in to change notification settings - Fork 2k
Go: Add overlay annotations from script #21370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7ef60a8
Update the overlay annotation script for go
jbj c56feb7
Go: annotate the standard library with for overlay
jbj f32f853
Mark various files as `overlay[local]`
owen-mc e9df914
Add overlay annotations in 4 PrintAst tests
owen-mc 99f4930
Explicitly mark DataFlowNodes.qll as overlay[local]
owen-mc df9f8ee
Merge branch 'main' into owen-mc/go/overlay-annotations
owen-mc b8b841c
Add `overlay[loca]` in 4 more tests
owen-mc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is overly conservative. There are plenty of files in that folder that correspond to java files with
overlay[local?]on them. But I don't think it's worth changing it, since we have DCA runs that show good results. Next time someone works on go overlay this could be a starting point for them.