Skip to content

Experiment #21489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asgerf wants to merge 2 commits into from

JS: Squash and rebase unified language lib work

613173a
Select commit
Loading
Failed to load commit list.
Closed

Experiment #21489

JS: Squash and rebase unified language lib work
613173a
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Mar 17, 2026 in 15s

6 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 6 configurations present on refs/heads/main were not found:

Actions workflow (rust-analysis.yml)

  • ❓  .github/workflows/rust-analysis.yml:analyze/language:rust

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 50 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 8 in javascript/ql/lib/semmle/javascript/internal/unified/DataFlowSteps.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
JSUnified
Loading
.

Check warning on line 99 in javascript/ql/lib/semmle/javascript/internal/unified/DataFlowSteps.qll

See this annotation in the file changed.

Code scanning / CodeQL

Cannot inline predicate across overlay frontier Warning

This possibly local non-private inline predicate will not be inlined across the overlay frontier. This may negatively affect evaluation performance. Consider adding an overlay[caller] or overlay[caller?] annotation to allow inlining across the overlay frontier. Note that adding an overlay[caller] or overlay[caller?] annotation affects semantics under overlay evaluation.

Check warning on line 5 in javascript/ql/lib/semmle/javascript/internal/unified/JSUnified.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

JS is only different by casing from Js that is used elsewhere for modules.

Check warning on line 388 in javascript/ql/lib/semmle/javascript/internal/unified/JSUnified.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 13 in javascript/ql/lib/semmle/javascript/internal/unified/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Singleton set literal Warning

Singleton set literal can be replaced by its member.

Check warning on line 204 in javascript/ql/lib/semmle/javascript/internal/unified/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 206 in javascript/ql/lib/semmle/javascript/internal/unified/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 242 in javascript/ql/lib/semmle/javascript/internal/unified/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Candidate predicate not marked as `nomagic` Warning

Candidate predicate to
importStep
Loading
is not marked as nomagic.

Check warning on line 119 in javascript/ql/lib/semmle/javascript/internal/unified/Transforms.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the common misspelling 'succesful', which should instead be 'successful'.

Check warning on line 135 in javascript/ql/lib/semmle/javascript/internal/unified/Transforms.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 453 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/AST.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

AST is only different by casing from Ast that is used elsewhere for modules.

Check warning on line 209 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/BasicBlockInternal.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

Js is only different by casing from JS that is used elsewhere for modules.

Check warning on line 1633 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/Expr.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

InstanceofExpr is only different by casing from InstanceOfExpr that is used elsewhere for classes.

Check warning on line 9 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/NPM.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
minimal
Loading
.

Check warning on line 347 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/NPM.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning

This predicate starts with 'get' but does not return a value.

Check warning on line 17 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/PathConcatenation.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 25 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/PathConcatenation.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 29 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/PathConcatenation.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 1004 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/Stmt.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

ForEachStmt is only different by casing from ForeachStmt that is used elsewhere for classes.

Check warning on line 65 in javascript/ql/lib/semmle/javascript/internal/unified/minimal/XML.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase Warning

Acronyms in isCDATA should be PascalCase/camelCase.

Check warning on line 6 in javascript/ql/lib/utils/test/InlineFlowTestUnified.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning test

Redundant import, the module is already imported inside
semmle.javascript.internal.unified.minimal.Locations
Loading
.

Check warning on line 7 in javascript/ql/lib/utils/test/InlineFlowTestUnified.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning test

Redundant import, the module is already imported inside
semmle.javascript.internal.unified.minimal.minimal
Loading
.

Check warning on line 1 in javascript/ql/lib/utils/test/internal/UnifiedInlineExpectationsTestImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning test

JS is only different by casing from Js that is used elsewhere for modules.

Check warning on line 585 in shared/unified/codeql/unified/UnifiedDataFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 1040 in shared/unified/codeql/unified/UnifiedDataFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.