Skip to content

C#: Replace CFG with the shared implementation. #21513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aschackmull wants to merge 15 commits into from

C#: Fix UncheckedCastInEquals.

c4bac37
Select commit
Loading
Failed to load commit list.
Closed

C#: Replace CFG with the shared implementation. #21513

C#: Fix UncheckedCastInEquals.
c4bac37
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Mar 20, 2026 in 3s

4 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 4 configurations present on refs/heads/main were not found:

Actions workflow (rust-analysis.yml)

  • ❓  .github/workflows/rust-analysis.yml:analyze/language:rust

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 4 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 8 in csharp/ql/lib/semmle/code/csharp/commons/Constants.qll

See this annotation in the file changed.

Code scanning / CodeQL

Candidate predicate not marked as `nomagic` Warning

Candidate predicate to
isConstantCondition
Loading
is not marked as nomagic.

Check warning on line 25 in csharp/ql/lib/semmle/code/csharp/controlflow/ControlFlowGraph.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

CS is only different by casing from Cs that is used elsewhere for modules.

Check warning on line 752 in csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for bb, or def, or i, but the QLDoc mentions lastRefRedef

Check warning on line 5 in csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/SsaReadPositionSpecific.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

CS is only different by casing from Cs that is used elsewhere for modules.