Skip to content

Commit e4d6875

Browse files
asizikovCopilot
andcommitted
fix: address breadcrumb review feedback
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 3817a73 commit e4d6875

2 files changed

Lines changed: 40 additions & 17 deletions

File tree

src/App.css

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1329,12 +1329,29 @@ td.cost-centers-view__num {
13291329
align-items: center;
13301330
gap: 10px;
13311331
flex-wrap: wrap;
1332+
list-style: none;
1333+
margin: 0;
1334+
padding: 0;
1335+
}
1336+
1337+
.user-details__breadcrumbItem {
1338+
display: inline-flex;
1339+
align-items: center;
1340+
gap: 10px;
1341+
}
1342+
1343+
.user-details__breadcrumbItem:not(:last-child)::after {
1344+
content: '/';
1345+
font-size: 18px;
1346+
font-weight: 600;
1347+
color: #8c959f;
13321348
}
13331349

13341350
.user-details__breadcrumb {
1351+
font: inherit;
13351352
font-size: 18px;
13361353
font-weight: 600;
1337-
color: #0969da;
1354+
color: #57606a;
13381355
background: transparent;
13391356
border: none;
13401357
padding: 0;
@@ -1343,6 +1360,7 @@ td.cost-centers-view__num {
13431360
}
13441361

13451362
.user-details__breadcrumb--link {
1363+
color: #0969da;
13461364
cursor: pointer;
13471365
}
13481366

@@ -1356,10 +1374,12 @@ td.cost-centers-view__num {
13561374
border-radius: 4px;
13571375
}
13581376

1359-
.user-details__breadcrumb-separator {
1360-
font-size: 18px;
1361-
font-weight: 600;
1362-
color: #8c959f;
1377+
.user-details__breadcrumbItem--current {
1378+
color: #1f2328;
1379+
}
1380+
1381+
.user-details__breadcrumbItem--current .user-details__heading {
1382+
color: inherit;
13631383
}
13641384

13651385
.user-details__heading {

src/views/UserDetailsView.tsx

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -147,18 +147,21 @@ export function UserDetailsView({ user, rangeStart, rangeEnd, onBackToUsers }: U
147147
<section className="user-details">
148148
<div className="user-details__header">
149149
<div className="user-details__titleGroup">
150-
<nav className="user-details__breadcrumbs" aria-label="Breadcrumb">
151-
{onBackToUsers ? (
152-
<button type="button" className="user-details__breadcrumb user-details__breadcrumb--link" onClick={onBackToUsers}>
153-
users
154-
</button>
155-
) : (
156-
<span className="user-details__breadcrumb">users</span>
157-
)}
158-
<span className="user-details__breadcrumb-separator" aria-hidden="true">
159-
/
160-
</span>
161-
<h2 className="user-details__heading">{user.username}</h2>
150+
<nav aria-label="Breadcrumb">
151+
<ol className="user-details__breadcrumbs">
152+
<li className="user-details__breadcrumbItem">
153+
{onBackToUsers ? (
154+
<button type="button" className="user-details__breadcrumb user-details__breadcrumb--link" onClick={onBackToUsers}>
155+
users
156+
</button>
157+
) : (
158+
<span className="user-details__breadcrumb">users</span>
159+
)}
160+
</li>
161+
<li className="user-details__breadcrumbItem user-details__breadcrumbItem--current" aria-current="page">
162+
<h2 className="user-details__heading">{user.username}</h2>
163+
</li>
164+
</ol>
162165
</nav>
163166
</div>
164167

0 commit comments

Comments
 (0)