Skip to content

Commit f07eb55

Browse files
asizikovCopilot
andcommitted
fix: address usage billing review feedback
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 9265e9d commit f07eb55

4 files changed

Lines changed: 17 additions & 5 deletions

File tree

src/components/ui/BillingTotalsCards.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,16 @@ describe('BillingTotalsCards', () => {
4848
expect(html).toContain(EXISTING_DISCOUNT_DISCLAIMER)
4949
expect(html).not.toContain('Promotional amounts are used in this simulation.')
5050
})
51+
52+
it('formats included discount rows with a single explicit minus sign', () => {
53+
const html = renderToStaticMarkup(createElement(BillingTotalsCards, {
54+
...BASE_PROPS,
55+
pruDiscountAmount: -1,
56+
aicDiscountAmount: -2.34,
57+
}))
58+
59+
expect(html).toContain('−$1.00')
60+
expect(html).toContain('−$2.34')
61+
expect(html).not.toContain('−$-')
62+
})
5163
})

src/components/ui/BillingTotalsCards.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export function BillingTotalsCards({
8585
</div>
8686
<div className="flex justify-between items-center text-[13px] text-fg-muted tabular-nums">
8787
<span>Included PRUs</span>
88-
<span>{formatUsd(pruDiscountAmount)}</span>
88+
<span>{formatUsd(Math.abs(pruDiscountAmount))}</span>
8989
</div>
9090
<div className="pt-[6px] border-t border-dotted border-border-muted flex flex-col gap-[6px]">
9191
<div className="flex justify-between items-center text-[13px] text-fg-default tabular-nums">
@@ -125,7 +125,7 @@ export function BillingTotalsCards({
125125
</div>
126126
<div className="flex justify-between items-center text-[13px] text-fg-muted tabular-nums">
127127
<span>Included AICs</span>
128-
<span>{formatUsd(aicDiscountAmount)}</span>
128+
<span>{formatUsd(Math.abs(aicDiscountAmount))}</span>
129129
</div>
130130
<div className="pt-[6px] border-t border-dotted border-border-muted flex flex-col gap-[6px]">
131131
<div className="flex justify-between items-center text-[13px] text-fg-default tabular-nums">

src/views/ModelsView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ export function ModelsView({
279279
</>
280280
)}
281281
<DualAxisLineChart
282-
title={`Daily AI Credits gross cost (${selectedModel})`}
282+
title={`Daily AI Credits gross and net cost (${selectedModel})`}
283283
labels={filledPerModelDailyData.map((day) => day.date)}
284284
series={[
285285
{

src/views/UserDetailsView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ export function UserDetailsView({
304304
{!isNativeAiCredits && <th className={thNum}>PRUs</th>}
305305
<th className={thNum}>AICs</th>
306306
{isNativeAiCredits && <th className={thNum}>AIC Gross Cost</th>}
307-
{isNativeAiCredits && <th className={thNum}>Included AICs</th>}
307+
{isNativeAiCredits && <th className={thNum}>Included Discount</th>}
308308
{!isNativeAiCredits && <th className={thNum}>PRU Net Cost</th>}
309309
<th className={thNum}>AIC Net Cost</th>
310310
{!isNativeAiCredits && <th className={thNum}>Difference</th>}
@@ -326,7 +326,7 @@ export function UserDetailsView({
326326
{!isNativeAiCredits && <td className={tdNum}>{formatInt(row.requests)}</td>}
327327
<td className={tdNum}>{formatAic(row.aicQuantity)}</td>
328328
{isNativeAiCredits && <td className={tdNum}>{formatCost(row.aicGrossAmount)}</td>}
329-
{isNativeAiCredits && <td className={tdNum}>{formatCost(row.aicDiscountAmount)}</td>}
329+
{isNativeAiCredits && <td className={tdNum}>{formatCost(Math.abs(row.aicDiscountAmount))}</td>}
330330
{!isNativeAiCredits && <td className={tdNum}>{formatCost(row.netAmount)}</td>}
331331
<td className={tdNum}>{formatCost(row.aicNetAmount)}</td>
332332
{!isNativeAiCredits && (

0 commit comments

Comments
 (0)