Skip to content

Commit 1c47b67

Browse files
DanWahlinCopilot
andcommitted
exclude internal markdown from translations
Keep .github and skill definition Markdown out of Co-op Translator output and prevent the Translation Polisher from reviewing or editing those generated paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 70a825b commit 1c47b67

2 files changed

Lines changed: 21 additions & 3 deletions

File tree

.github/workflows/co-op-translator.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ on:
1414
- "!translations/**"
1515
- "!translated_images/**"
1616
- "!.github/**"
17+
- "!samples/skills/**"
1718

1819
permissions:
1920
contents: write
@@ -92,6 +93,16 @@ jobs:
9293
echo "co-op-review is not available in the installed Co-op Translator package; skipping."
9394
fi
9495
96+
- name: Remove excluded translations
97+
run: |
98+
for language in $TRANSLATION_LANGUAGES; do
99+
rm -rf \
100+
"translations/$language/.github" \
101+
"translations/$language/samples/skills" \
102+
"translated_images/$language/.github" \
103+
"translated_images/$language/samples/skills"
104+
done
105+
95106
- name: Upload Co-op Translator logs
96107
if: always()
97108
uses: actions/upload-artifact@v4

.github/workflows/translation-polisher.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ Stop with a no-op only if all of these are true:
7777
2. The pull request body already contains an up-to-date managed `## Translation Quality Review` section with one grade row for every changed translated Markdown file.
7878
3. Every existing grade in the managed review section is **A- or higher**.
7979

80-
If the latest commit appears to be from this Translation Polisher workflow but the pull request body is missing the `## Translation Quality Review` section, do not edit files. Still review and grade the changed translated Markdown files, update the pull request body, and add a concise comment if useful.
80+
If the latest commit appears to be from this Translation Polisher workflow but the pull request body is missing the `## Translation Quality Review` section, do not edit files. Still review and grade the changed translated Markdown files and update the pull request body.
8181

82-
If the pull request body already contains a managed `## Translation Quality Review` section and any row is graded **B+ or lower**, treat those files as required repair targets. Review and polish those files again before deciding whether to push changes or leave a blocking comment.
82+
If the pull request body already contains a managed `## Translation Quality Review` section and any row is graded **B+ or lower**, treat those files as required repair targets. Review and polish those files again before deciding whether to push changes or report blocking issues in the managed pull request body section.
8383

8484
Do not add churn. If the translation is already good enough and the PR body already has current A- or higher grades, leave it unchanged.
8585

@@ -89,6 +89,13 @@ You may edit only translated Markdown files:
8989

9090
- `translations/**/*.md`
9191

92+
Exclude these generated translation paths from review, grading, and edits:
93+
94+
- `translations/*/.github/**`
95+
- `translations/*/samples/skills/**`
96+
97+
Leave skill definition Markdown in English.
98+
9299
Do not edit:
93100

94101
- English source files
@@ -103,7 +110,7 @@ Do not edit:
103110
2. Compare each changed translated Markdown file with its corresponding English source file.
104111
- Example: compare `translations/es/README.md` with `README.md`.
105112
- Example: compare `translations/es/03-development-workflows/README.md` with `03-development-workflows/README.md`.
106-
3. Focus on files changed by the pull request, not every translated file in the repository.
113+
3. Focus on files changed by the pull request, not every translated file in the repository. Ignore excluded translation paths under `translations/*/.github/**` and `translations/*/samples/skills/**`.
107114
4. If the pull request body already has a managed `## Translation Quality Review` section, identify files with grades below A- and repair those files first.
108115
5. Preserve Markdown structure exactly unless a link or heading fix is required.
109116
6. Apply the shared quality rules and the language quality profile for each target language present in the pull request.

0 commit comments

Comments
 (0)