You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove comment safe outputs from the Translation Polisher, cap branch pushes at one, and make the PR body the only place for translation quality review details.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy file name to clipboardExpand all lines: .github/workflows/translation-polisher.md
+7-18Lines changed: 7 additions & 18 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,11 +28,6 @@ safe-outputs:
28
28
- github.com
29
29
noop:
30
30
report-as-issue: false
31
-
add-comment:
32
-
target: "*"
33
-
pull-requests: true
34
-
max: 1
35
-
github-token: ${{ secrets.GH_AW_GITHUB_TOKEN }}
36
31
add-labels:
37
32
allowed: [translation-polished]
38
33
max: 1
@@ -50,6 +45,7 @@ safe-outputs:
50
45
allowed-files:
51
46
- "translations/**/*.md"
52
47
if-no-changes: "ignore"
48
+
max: 1
53
49
github-token: ${{ secrets.GH_AW_GITHUB_TOKEN }}
54
50
---
55
51
@@ -123,12 +119,12 @@ Do not edit:
123
119
124
120
9. Perform a final review of each changed target-language file against its English source file. Grade each file using A, A-, B+, B, B-, C, D, or F.
125
121
10. Continue improving the translation until every changed target-language file earns **A- or higher**.
126
-
11. If any changed target-language file remains below A- after reasonable polishing, do not push changes and do not add the `translation-polished` label. Update the pull request body with `Translation status: Needs polish` and add a pull request comment explaining the blocking issues and current file grades.
122
+
11. If any changed target-language file remains below A- after reasonable polishing, do not push changes and do not add the `translation-polished` label. Update the pull request body with `Translation status: Needs polish` and include the blocking issues and current file grades in the managed review section.
127
123
12. Review your final diff. If it contains anything outside `translations/**/*.md`, revert those changes.
128
124
13. Push your changes to the target pull request branch using the safe output only when every changed target-language file is A- or higher.
129
125
14. Update the pull request body with a final per-file grade table using the instructions in **Pull request body update**.
130
126
15. Add the `translation-polished` label only when every changed target-language file is A- or higher.
131
-
16.Add a short pull request comment summarizing what was polished, which languages were touched, and the final grade range.
127
+
16.Do not add a pull request comment. The managed pull request body section is the source of truth for review status, grades, and notes.
132
128
133
129
## Safe output limits
134
130
@@ -137,9 +133,9 @@ Emit each safe output type at most once:
137
133
- At most one `push_to_pull_request_branch`.
138
134
- At most one `update_pull_request`.
139
135
- At most one `add_labels`, and only when the `translation-polished` label is not already present on the pull request.
140
-
-At most one`add_comment`.
136
+
-Do not emit`add_comment`; comments are not an allowed safe output for this workflow.
141
137
142
-
Do not emit duplicate label or comment requests. If a label is already present, do not emit an `add_labels` request for it. If you emit `add_labels`, include the target pull request number as `item_number`. If you need to report both a quality summary and polishing summary, combine them into the single allowed pull request comment.
138
+
Do not emit duplicate branch push, pull request update, label, or comment requests. If a label is already present, do not emit an `add_labels` request for it. If you emit `add_labels`, include the target pull request number as `item_number`. Put the quality summary and polishing summary in the single managed pull request body section.
143
139
144
140
## Quality checklist
145
141
@@ -257,13 +253,6 @@ Use `Translation status: Accepted` only when every changed translated Markdown f
257
253
258
254
Include one row for every changed translated Markdown file in the target pull request. Keep notes concise and specific. For below-threshold files, the note must state the highest-impact issue to fix.
259
255
260
-
## Pull request comment
261
-
262
-
After polishing, add a concise comment with:
263
-
264
-
1. The pull request number reviewed.
265
-
2. The languages touched.
266
-
3. The final grade range across changed files. Only report `A-` or higher as accepted.
267
-
4. A short summary of improvements, such as link-label translation, terminology consistency, and readability polish.
256
+
## Pull request comments
268
257
269
-
If no changes are needed, use a no-op and do not comment.
258
+
Do not add pull request comments. Use only the managed `## Translation Quality Review` pull request body section for grades, notes, and status.
0 commit comments