feat: add deployment for bookkeeper app#155
Conversation
|
can l please have a review thank you |
|
@leecurtis269-maker Could you review this PR when you have a moment? |
|
@leecurtis269-maker Reminder: PR #155 is ready for review. Once approvals and checks pass, you can enable auto-merge from the GitHub UI if needed. |
|
PR Summary: This change adds deployment support for the bookkeeper sample app. It includes a Dockerfile, docker-compose, Kubernetes manifests, local deployment docs, and CI workflows. PRs now run tests plus a preview Docker build workflow; main pushes run build/push and optional deploy when KUBE_CONFIG is set. Please review the workflow and merge once checks pass. |
|
Updated the PR title to for clarity. I attempted to add a label as well, but the repo permissions do not allow creating labels from this integration. |
|
Thanks for the PR @leecurtis269-maker. The code in the course is designed to generate specific output for Copilot CLI reviews and other actions performed throughout the course so we're not looking to change it right now or add additional features (pretty cool that you added docker and k8s support though!). We have to keep it at a beginner level and most of those topics go outside the bounds of "beginner" level knowledge. If we do make changes in the future we'll refer back to this PR though. Thank you. |
Adds Dockerfile, docker-compose, Kubernetes manifests, and CI workflow to build/push/deploy the bookkeeper sample app. PRs now run tests and a dedicated preview Docker build workflow, while main pushes run the build/push and deploy jobs. Updated to avoid secret evaluation in PR deploy path so forked PR workflows no longer fail. Includes local deployment instructions and verified pytest coverage.