Skip to content

feat: add deployment for bookkeeper app#155

Closed
leecurtis269-maker wants to merge 5 commits into
github:mainfrom
leecurtis269-maker:feature/deploy-bookkeeper
Closed

feat: add deployment for bookkeeper app#155
leecurtis269-maker wants to merge 5 commits into
github:mainfrom
leecurtis269-maker:feature/deploy-bookkeeper

Conversation

@leecurtis269-maker

@leecurtis269-maker leecurtis269-maker commented Jun 3, 2026

Copy link
Copy Markdown

Adds Dockerfile, docker-compose, Kubernetes manifests, and CI workflow to build/push/deploy the bookkeeper sample app. PRs now run tests and a dedicated preview Docker build workflow, while main pushes run the build/push and deploy jobs. Updated to avoid secret evaluation in PR deploy path so forked PR workflows no longer fail. Includes local deployment instructions and verified pytest coverage.

@leecurtis269-maker

Copy link
Copy Markdown
Author

can l please have a review thank you
leecurtis269-maker

Copy link
Copy Markdown
Author

@leecurtis269-maker Could you review this PR when you have a moment?

Copy link
Copy Markdown
Author

@leecurtis269-maker Reminder: PR #155 is ready for review. Once approvals and checks pass, you can enable auto-merge from the GitHub UI if needed.

Copy link
Copy Markdown
Author

PR Summary: This change adds deployment support for the bookkeeper sample app. It includes a Dockerfile, docker-compose, Kubernetes manifests, local deployment docs, and CI workflows. PRs now run tests plus a preview Docker build workflow; main pushes run build/push and optional deploy when KUBE_CONFIG is set. Please review the workflow and merge once checks pass.

@leecurtis269-maker leecurtis269-maker changed the title chore: add deployment for bookkeeper app feat: add deployment for bookkeeper app Jun 3, 2026

Copy link
Copy Markdown
Author

Updated the PR title to for clarity. I attempted to add a label as well, but the repo permissions do not allow creating labels from this integration.

@DanWahlin

Copy link
Copy Markdown
Collaborator

Thanks for the PR @leecurtis269-maker. The code in the course is designed to generate specific output for Copilot CLI reviews and other actions performed throughout the course so we're not looking to change it right now or add additional features (pretty cool that you added docker and k8s support though!). We have to keep it at a beginner level and most of those topics go outside the bounds of "beginner" level knowledge. If we do make changes in the future we'll refer back to this PR though. Thank you.

@DanWahlin DanWahlin closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants