Skip to content

Commit 13ba8b0

Browse files
address PR comments
1 parent c694930 commit 13ba8b0

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

cli/cmd/engine-cli/main.go

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -273,17 +273,20 @@ func runEngine(cmd *cobra.Command, args []string) error {
273273
}
274274

275275
env := runner.Environment{
276-
JobID: jobID,
277-
APIToken: githubToken,
278-
APIURL: apiURL,
279-
JobNonce: mockServer.Nonce(),
280-
InferenceToken: githubToken,
281-
InferenceURL: inferenceURL,
282-
GitToken: githubToken,
283-
SelectedEngine: selectedEngine,
284-
SelectedModel: selectedModel,
285-
DefaultModel: defaultModel,
286-
AvailableModels: availableModels,
276+
JobID: jobID,
277+
APIToken: githubToken,
278+
APIURL: apiURL,
279+
JobNonce: mockServer.Nonce(),
280+
InferenceToken: githubToken,
281+
InferenceURL: inferenceURL,
282+
GitToken: githubToken,
283+
}
284+
285+
if enableModelSelection {
286+
env.SelectedEngine = selectedEngine
287+
env.SelectedModel = selectedModel
288+
env.DefaultModel = defaultModel
289+
env.AvailableModels = availableModels
287290
}
288291

289292
result := runner.Run(ctx, command, env, runner.Options{WorkingDir: workingDir}, runnerCallbacks)

src/client.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -540,18 +540,21 @@ export function resolveSelectedModel(
540540
options?: ResolveSelectedModelOptions,
541541
): string | undefined {
542542
// Model selection must be explicitly enabled via feature flag
543-
if (!job.features?.model_selection) {
543+
if (job.features?.model_selection !== true) {
544544
return undefined;
545545
}
546546

547-
const availableModels = job.available_models?.filter((model) => model.trim().length > 0) ?? [];
547+
const availableModels = job.available_models
548+
?.map((model) => model.trim())
549+
.filter((model) => model.length > 0) ?? [];
548550

549551
const candidates = [
550552
options?.preferredModel,
551553
job.selected_model,
552554
job.default_model,
553555
options?.fallbackModel,
554-
].filter((model): model is string => Boolean(model && model.trim().length > 0));
556+
].map((model) => model?.trim())
557+
.filter((model): model is string => Boolean(model && model.length > 0));
555558

556559
if (availableModels.length === 0) {
557560
return candidates[0];

0 commit comments

Comments
 (0)