Skip to content

Commit 8726da3

Browse files
remove selectedEngine
1 parent 7a64a2f commit 8726da3

5 files changed

Lines changed: 0 additions & 19 deletions

File tree

cli/cmd/engine-cli/main.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ var (
3434
commitEmail string
3535
assignmentID string
3636
enableModelSelection bool
37-
selectedEngine string
3837
selectedModel string
3938
defaultModel string
4039
availableModels []string
@@ -95,7 +94,6 @@ func init() {
9594
runCmd.Flags().StringVar(&commitEmail, "commit-email", "engine-cli@users.noreply.github.com", "Git author email for commits")
9695
runCmd.Flags().StringVar(&assignmentID, "assignment-id", "", "Assignment ID to enable cross-run history persistence")
9796
runCmd.Flags().BoolVar(&enableModelSelection, "enable-model-selection", false, "Enable the model selection feature flag in the job response")
98-
runCmd.Flags().StringVar(&selectedEngine, "selected-engine", "", "Selected engine family for this job (for example: claude or codex)")
9997
runCmd.Flags().StringVar(&selectedModel, "selected-model", "", "Selected model for this job")
10098
runCmd.Flags().StringVar(&defaultModel, "default-model", "", "Default model for this engine")
10199
runCmd.Flags().StringSliceVar(&availableModels, "available-model", nil, "Available model for this engine (repeatable)")
@@ -162,7 +160,6 @@ func runEngine(cmd *cobra.Command, args []string) error {
162160
CommitLogin: commitLogin,
163161
CommitEmail: commitEmail,
164162
EnableModelSelection: enableModelSelection,
165-
SelectedEngine: selectedEngine,
166163
SelectedModel: selectedModel,
167164
DefaultModel: defaultModel,
168165
AvailableModels: availableModels,
@@ -286,7 +283,6 @@ func runEngine(cmd *cobra.Command, args []string) error {
286283
}
287284

288285
if enableModelSelection {
289-
env.SelectedEngine = selectedEngine
290286
env.SelectedModel = selectedModel
291287
env.DefaultModel = defaultModel
292288
env.AvailableModels = availableModels

cli/internal/runner/runner.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ type Environment struct {
2323
InferenceToken string
2424
InferenceURL string
2525
GitToken string
26-
SelectedEngine string
2726
SelectedModel string
2827
DefaultModel string
2928
AvailableModels []string
@@ -142,10 +141,6 @@ func buildEnv(env Environment, extra map[string]string) []string {
142141
platformVars["GITHUB_INFERENCE_URL"] = env.InferenceURL
143142
}
144143

145-
if env.SelectedEngine != "" {
146-
platformVars["GITHUB_SELECTED_ENGINE"] = env.SelectedEngine
147-
}
148-
149144
if env.SelectedModel != "" {
150145
platformVars["GITHUB_SELECTED_MODEL"] = env.SelectedModel
151146
}

cli/internal/server/server.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ type JobConfig struct {
3232
CommitEmail string
3333
MCPProxyURL string
3434
EnableModelSelection bool
35-
SelectedEngine string
3635
SelectedModel string
3736
DefaultModel string
3837
AvailableModels []string
@@ -217,10 +216,6 @@ func (s *MockPlatformServer) handleGetJob(w http.ResponseWriter, r *http.Request
217216
"model_selection": true,
218217
}
219218

220-
if s.jobConfig.SelectedEngine != "" {
221-
response["selected_engine"] = s.jobConfig.SelectedEngine
222-
}
223-
224219
if s.jobConfig.SelectedModel != "" {
225220
response["selected_model"] = s.jobConfig.SelectedModel
226221
}

docs/integration-guide.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ The platform injects these environment variables into the engine process at runt
9494
| `GITHUB_INFERENCE_TOKEN` | Yes | Token used by your inference client / SDK for model calls. |
9595
| `GITHUB_INFERENCE_URL` | Yes | Base URL for the inference API (e.g. Copilot API). Use this along with `GITHUB_INFERENCE_TOKEN` to make LLM inference calls. |
9696
| `GITHUB_GIT_TOKEN` | Yes | Token used for authenticated `git clone` / `git push`. |
97-
| `GITHUB_SELECTED_ENGINE` | No | Engine family selected for this run (e.g. `claude`, `codex`). Only set when model selection is enabled. |
9897
| `GITHUB_SELECTED_MODEL` | No | Model selected by the platform for this run. Only set when model selection is enabled. |
9998
| `GITHUB_DEFAULT_MODEL` | No | Default model for the selected engine. Only set when model selection is enabled. |
10099
| `GITHUB_AVAILABLE_MODELS` | No | JSON array of models the engine can choose from (e.g. `["claude-sonnet-4.5","claude-opus-4.1"]`). Only set when model selection is enabled. |
@@ -151,7 +150,6 @@ Headers:
151150
"features": {
152151
"model_selection": true
153152
},
154-
"selected_engine": "claude",
155153
"selected_model": "claude-sonnet-4.5",
156154
"default_model": "claude-sonnet-4.5",
157155
"available_models": ["claude-sonnet-4.5", "claude-opus-4.1"],
@@ -171,7 +169,6 @@ Headers:
171169
| `commit_login` | Git author name for commits. |
172170
| `commit_email` | Git author email for commits. |
173171
| `features` | Optional feature flags. Currently supports `model_selection` (boolean). |
174-
| `selected_engine` | Engine family selected for this run (e.g. `claude` or `codex`). Present when `features.model_selection` is `true`. |
175172
| `selected_model` | Model selected by the platform for this run. Present when `features.model_selection` is `true`. |
176173
| `default_model` | Default model for the selected engine. Present when `features.model_selection` is `true`. |
177174
| `available_models` | List of models the engine can choose from. Present when `features.model_selection` is `true`. |

src/client.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,8 +485,6 @@ export interface JobDetails {
485485
commit_login: string;
486486
commit_email: string;
487487
mcp_proxy_url?: string;
488-
/** Engine family selected for this run (e.g., "claude" or "codex"). Present when model selection is enabled. */
489-
selected_engine?: string;
490488
/** Model selected by the platform for this run. Present when model selection is enabled. */
491489
selected_model?: string;
492490
/** Default model for the selected engine. Present when model selection is enabled. */

0 commit comments

Comments
 (0)