Skip to content

Commit f656e13

Browse files
authored
Further polish
1 parent 72b5c9c commit f656e13

File tree

3 files changed

+37
-8
lines changed

3 files changed

+37
-8
lines changed

cli/cmd/engine-cli/display.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ func printEvent(event server.ProgressEvent) bool {
6767
case "comment_reply":
6868
return printCommentReply(event.Content)
6969
default:
70+
// Custom namespace/kind — don't render inline, counted in summary
7071
return false
7172
}
7273
}

cli/cmd/engine-cli/main.go

Lines changed: 36 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,9 @@ func runEngine(cmd *cobra.Command, args []string) error {
149149

150150
prNumber := setup.PRNumber
151151

152-
// Track suppressed events for the summary line
153-
suppressedCount := 0
152+
// Track suppressed events for the summary
153+
type eventKey struct{ namespace, kind string }
154+
suppressedCounts := make(map[eventKey]int)
154155

155156
callbacks := server.Callbacks{
156157
OnJobFetched: func() {
@@ -175,9 +176,10 @@ func runEngine(cmd *cobra.Command, args []string) error {
175176
return
176177
}
177178

178-
// Try to print the event; if nothing was printed, count it as suppressed
179+
// Try to print the event; if nothing was printed, track it
179180
if !printEvent(event) {
180-
suppressedCount++
181+
kind := resolveKind(event.Kind, event.Content)
182+
suppressedCounts[eventKey{event.Namespace, kind}]++
181183
}
182184
},
183185
}
@@ -256,12 +258,38 @@ func runEngine(cmd *cobra.Command, args []string) error {
256258

257259
// Summary
258260
allEvents := mockServer.Events()
259-
displayed := len(allEvents) - suppressedCount
260-
fmt.Println()
261+
totalSuppressed := 0
262+
for _, c := range suppressedCounts {
263+
totalSuppressed += c
264+
}
265+
displayed := len(allEvents) - totalSuppressed
266+
267+
fmt.Println(separator)
261268
if result.ExitCode == 0 {
262-
fmt.Printf(" %s %s\n", greenStyle.Render(""), mutedStyle.Render(fmt.Sprintf("Done (%d events, %d displayed)", len(allEvents), displayed)))
269+
fmt.Printf(" %s %s\n", greenStyle.Render(""), boldStyle.Render("Done"))
263270
} else {
264-
fmt.Printf(" %s %s\n", redStyle.Render("✗"), mutedStyle.Render(fmt.Sprintf("Failed with exit code %d (%d events)", result.ExitCode, len(allEvents))))
271+
fmt.Printf(" %s %s\n", redStyle.Render("●"), boldStyle.Render(fmt.Sprintf("Failed (exit code %d)", result.ExitCode)))
272+
}
273+
fmt.Printf(" %s %d displayed, %d total\n", dimStyle.Render("events:"), displayed, len(allEvents))
274+
if len(suppressedCounts) > 0 {
275+
// Only show non-platform namespaces in the "other" section
276+
hasCustom := false
277+
for key := range suppressedCounts {
278+
if key.namespace != "" && key.namespace != "sessions-v2" {
279+
hasCustom = true
280+
break
281+
}
282+
}
283+
if hasCustom {
284+
fmt.Printf(" %s\n", dimStyle.Render("other:"))
285+
for key, count := range suppressedCounts {
286+
if key.namespace == "" || key.namespace == "sessions-v2" {
287+
continue
288+
}
289+
label := key.namespace + ":" + key.kind
290+
fmt.Printf(" %s %s\n", mutedStyle.Render(label), mutedStyle.Render(fmt.Sprintf("(%d)", count)))
291+
}
292+
}
265293
}
266294

267295
// Save history

cli/engine-cli

4.69 KB
Binary file not shown.

0 commit comments

Comments
 (0)