-
Notifications
You must be signed in to change notification settings - Fork 0
SDK supports model selection #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kinseydurhamgrace
wants to merge
7
commits into
main
Choose a base branch
from
kdg/support-model-selection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+210
−19
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c694930
Improvements:
kinseydurhamgrace 13ba8b0
address PR comments
kinseydurhamgrace 7a64a2f
support model vendor
kinseydurhamgrace 8726da3
remove selectedEngine
kinseydurhamgrace 3f0265e
Add documentation
kinseydurhamgrace e72426b
change to support multiple vendors
kinseydurhamgrace 7147ce3
fix trim bug
kinseydurhamgrace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -485,6 +485,97 @@ export interface JobDetails { | |
| commit_login: string; | ||
| commit_email: string; | ||
| mcp_proxy_url?: string; | ||
| /** Model selected by the platform for this run. Present when model selection is enabled. */ | ||
| selected_model?: string; | ||
| /** Default model for the selected engine. Present when model selection is enabled. */ | ||
| default_model?: string; | ||
| /** Models the engine can choose from. Present when model selection is enabled. */ | ||
| available_models?: string[]; | ||
| /** Model vendors for filtering (e.g. ["Anthropic", "OpenAI"]). Present when model selection is enabled. */ | ||
| model_vendors?: string[]; | ||
| /** Feature flags enabled for this job. */ | ||
| features?: { | ||
| /** Whether the platform has enabled model selection for this job. */ | ||
| model_selection?: boolean; | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Check whether the platform has enabled model selection for this job. | ||
| * | ||
| * When this returns `false`, engines should use their own hardcoded model. | ||
| */ | ||
| export function isModelSelectionEnabled(job: Pick<JobDetails, "features">): boolean { | ||
| return job.features?.model_selection === true; | ||
| } | ||
|
|
||
| /** | ||
| * Resolve which model an engine should use for a job. | ||
| * | ||
| * Returns `undefined` when model selection is not enabled for the job | ||
| * (i.e. `features.model_selection` is not `true`), allowing engines that | ||
| * do not support model selection to ignore it entirely. | ||
|
Comment on lines
+515
to
+517
|
||
| * | ||
| * When enabled, the selection order is: | ||
| * 1) caller preferred model | ||
| * 2) model selected by platform (`selected_model`) | ||
| * 3) platform-provided engine default (`default_model`) | ||
| * 4) caller fallback model | ||
| * | ||
| * If `available_models` is present the resolved model must appear in that | ||
| * list. When no candidate matches, the first available model is returned | ||
| * and a warning is logged if `selected_model` was set but missing from the | ||
| * list (indicates a platform misconfiguration). | ||
| */ | ||
| /** Options for {@link resolveSelectedModel}. */ | ||
| export interface ResolveSelectedModelOptions { | ||
| /** Model the engine prefers to use, checked first. */ | ||
| preferredModel?: string; | ||
| /** Model to fall back to when no platform-provided candidate matches. */ | ||
| fallbackModel?: string; | ||
| } | ||
|
|
||
| export function resolveSelectedModel( | ||
| job: Pick<JobDetails, "selected_model" | "default_model" | "available_models" | "features">, | ||
| options?: ResolveSelectedModelOptions, | ||
| ): string | undefined { | ||
| // Model selection must be explicitly enabled via feature flag | ||
| if (job.features?.model_selection !== true) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const availableModels = job.available_models | ||
| ?.map((model) => model.trim()) | ||
| .filter((model) => model.length > 0) ?? []; | ||
|
|
||
| const candidates = [ | ||
| options?.preferredModel, | ||
| job.selected_model, | ||
| job.default_model, | ||
| options?.fallbackModel, | ||
| ].map((model) => model?.trim()) | ||
| .filter((model): model is string => Boolean(model && model.length > 0)); | ||
|
|
||
| if (availableModels.length === 0) { | ||
| return candidates[0]; | ||
| } | ||
|
|
||
| for (const candidate of candidates) { | ||
| if (availableModels.includes(candidate)) { | ||
| return candidate; | ||
| } | ||
| } | ||
|
|
||
| // Warn when the platform-selected model is not in the available list | ||
| const trimmedSelectedModel = job.selected_model?.trim(); | ||
| if (trimmedSelectedModel && !availableModels.includes(trimmedSelectedModel)) { | ||
| console.warn( | ||
| `resolveSelectedModel: selected_model "${trimmedSelectedModel}" is not in available_models [${availableModels.join(", ")}]. ` + | ||
| `Falling back to "${availableModels[0]}".` | ||
| ); | ||
| } | ||
|
|
||
| return availableModels[0]; | ||
| } | ||
|
|
||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
--enable-model-selection, the mock job response will setfeatures.model_selection=trueeven if none of--selected-model,--default-model, or--available-modelare provided, resulting in a job payload with the feature enabled but no model information. Consider validating the flag combination and returning an error (or auto-populating a default) to avoid confusing local engine testing.