Merge pull request #216 from github/copilot/fix-review-comment-3268776043

fix: bound polling loop timeouts by remaining deadline time

Author: edburns

src/test/java/com/github/copilot/sdk/CopilotSessionTest.java

@@ -760,12 +760,30 @@ void testShouldGetLastSessionId() throws Exception {
                     .createSession(new SessionConfig().setOnPermissionRequest(PermissionHandler.APPROVE_ALL)).get();
 
             session.sendAndWait(new MessageOptions().setPrompt("Say hello")).get(60, TimeUnit.SECONDS);
+            String sessionId = session.getSessionId();
+            session.close();
 
-            String lastId = client.getLastSessionId().get(30, TimeUnit.SECONDS);
+            // Poll until getLastSessionId returns the expected value.
+            // Session state is persisted asynchronously; polling keeps fast
+            // machines fast and slow CI safe (mirrors Node.js/.NET patterns).
+            String lastId = null;
+            long deadline = System.currentTimeMillis() + 10_000;
+            while (System.currentTimeMillis() < deadline) {
+                long remaining = Math.max(1, deadline - System.currentTimeMillis());
+                long iterationTimeout = Math.min(remaining, 500);
+                try {
+                    lastId = client.getLastSessionId().get(iterationTimeout, TimeUnit.MILLISECONDS);
+                } catch (java.util.concurrent.TimeoutException ignored) {
+                    // RPC call took longer than the per-iteration cap; retry
+                    continue;
+                }
+                if (sessionId.equals(lastId)) {
+                    break;
+                }
+                Thread.sleep(50);
+            }
             assertNotNull(lastId, "Last session ID should not be null");
-            assertEquals(session.getSessionId(), lastId, "Last session ID should match the current session ID");
-
-            session.close();
+            assertEquals(sessionId, lastId, "Last session ID should match the current session ID");
         }
     }
 
@@ -840,11 +858,31 @@ void testShouldGetSessionMetadataById() throws Exception {
             var session = client
                     .createSession(new SessionConfig().setOnPermissionRequest(PermissionHandler.APPROVE_ALL)).get();
 
+            // Send a message to persist the session to disk
             session.sendAndWait(new MessageOptions().setPrompt("Say hello")).get(60, TimeUnit.SECONDS);
 
-            var metadata = client.getSessionMetadata(session.getSessionId()).get(30, TimeUnit.SECONDS);
-            assertNotNull(metadata, "Metadata should not be null for known session");
-            assertEquals(session.getSessionId(), metadata.getSessionId(), "Metadata session ID should match");
+            // Poll until metadata becomes available; the CLI persists session
+            // state asynchronously so it may not be queryable immediately
+            // (mirrors .NET WaitForConditionAsync pattern).
+            var sessionId = session.getSessionId();
+            com.github.copilot.sdk.json.SessionMetadata metadata = null;
+            long deadline = System.currentTimeMillis() + 10_000;
+            while (System.currentTimeMillis() < deadline) {
+                long remaining = Math.max(1, deadline - System.currentTimeMillis());
+                long iterationTimeout = Math.min(remaining, 500);
+                try {
+                    metadata = client.getSessionMetadata(sessionId).get(iterationTimeout, TimeUnit.MILLISECONDS);
+                } catch (java.util.concurrent.TimeoutException ignored) {
+                    // RPC call took longer than the per-iteration cap; retry
+                    continue;
+                }
+                if (metadata != null) {
+                    break;
+                }
+                Thread.sleep(50);
+            }
+            assertNotNull(metadata, "Timed out waiting for getSessionMetadata() to return the persisted session");
+            assertEquals(sessionId, metadata.getSessionId(), "Metadata session ID should match");
 
             // A non-existent session should return null
             var notFound = client.getSessionMetadata("non-existent-session-id").get(30, TimeUnit.SECONDS);