Fix test and clone implementation per PR feedback

- Fix sessionConfigListIndependence test to properly validate list independence by mutating original list after cloning
- Clone environment map in CopilotClientOptions for collection independence
- Add copilotClientOptionsEnvironmentIndependence test to validate environment map cloning
- Update CopilotClientOptions Javadoc to reflect environment map is now copied
- Apply spotless formatting

Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>

Author: Copilot

src/main/java/com/github/copilot/sdk/json/CopilotClientOptions.java

@@ -328,9 +328,9 @@ public CopilotClientOptions setUseLoggedInUser(Boolean useLoggedInUser) {
      * Creates a shallow clone of this {@code CopilotClientOptions} instance.
      * <p>
      * Array properties (like {@code cliArgs}) are copied into new arrays so that
-     * modifications to the clone do not affect the original. Other reference-type
-     * properties (like {@code environment}) are shared between the original and
-     * clone.
+     * modifications to the clone do not affect the original. The
+     * {@code environment} map is also copied to a new map instance. Other
+     * reference-type properties are shared between the original and clone.
      *
      * @return a clone of this options instance
      */
@@ -346,7 +346,7 @@ public CopilotClientOptions clone() {
         copy.logLevel = this.logLevel;
         copy.autoStart = this.autoStart;
         copy.autoRestart = this.autoRestart;
-        copy.environment = this.environment;
+        copy.environment = this.environment != null ? new java.util.HashMap<>(this.environment) : null;
         copy.githubToken = this.githubToken;
         copy.useLoggedInUser = this.useLoggedInUser;
         return copy;

src/main/java/com/github/copilot/sdk/json/ResumeSessionConfig.java

@@ -483,8 +483,8 @@ public ResumeSessionConfig setInfiniteSessions(InfiniteSessionConfig infiniteSes
      * Mutable collection properties are copied into new collection instances so
      * that modifications to those collections on the clone do not affect the
      * original. Other reference-type properties (like provider configuration,
-     * system messages, hooks, infinite session configuration, and handlers) are
-     * not deep-cloned; the original and the clone will share those objects.
+     * system messages, hooks, infinite session configuration, and handlers) are not
+     * deep-cloned; the original and the clone will share those objects.
      *
      * @return a clone of this config instance
      */

src/main/java/com/github/copilot/sdk/json/SessionConfig.java

@@ -520,8 +520,8 @@ public SessionConfig setConfigDir(String configDir) {
      * Mutable collection properties are copied into new collection instances so
      * that modifications to those collections on the clone do not affect the
      * original. Other reference-type properties (like provider configuration,
-     * system messages, hooks, infinite session configuration, and handlers) are
-     * not deep-cloned; the original and the clone will share those objects.
+     * system messages, hooks, infinite session configuration, and handlers) are not
+     * deep-cloned; the original and the clone will share those objects.
      *
      * @return a clone of this config instance
      */

src/test/java/com/github/copilot/sdk/ConfigCloneTest.java

@@ -7,7 +7,9 @@
 import static org.junit.jupiter.api.Assertions.*;
 
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 import org.junit.jupiter.api.Test;
 
@@ -24,9 +26,9 @@ void copilotClientOptionsCloneBasic() {
         original.setCliPath("/usr/local/bin/copilot");
         original.setLogLevel("debug");
         original.setPort(9000);
-        
+
         CopilotClientOptions cloned = original.clone();
-        
+
         assertEquals(original.getCliPath(), cloned.getCliPath());
         assertEquals(original.getLogLevel(), cloned.getLogLevel());
         assertEquals(original.getPort(), cloned.getPort());
@@ -37,23 +39,40 @@ void copilotClientOptionsArrayIndependence() {
         CopilotClientOptions original = new CopilotClientOptions();
         String[] args = {"--flag1", "--flag2"};
         original.setCliArgs(args);
-        
+
         CopilotClientOptions cloned = original.clone();
         cloned.getCliArgs()[0] = "--changed";
-        
+
         assertEquals("--flag1", original.getCliArgs()[0]);
         assertEquals("--changed", cloned.getCliArgs()[0]);
     }
 
+    @Test
+    void copilotClientOptionsEnvironmentIndependence() {
+        CopilotClientOptions original = new CopilotClientOptions();
+        Map<String, String> env = new HashMap<>();
+        env.put("KEY1", "value1");
+        original.setEnvironment(env);
+
+        CopilotClientOptions cloned = original.clone();
+
+        // Mutate the original environment map to test independence
+        env.put("KEY2", "value2");
+
+        // The cloned config should be unaffected by mutations to the original map
+        assertEquals(1, cloned.getEnvironment().size());
+        assertEquals(2, original.getEnvironment().size());
+    }
+
     @Test
     void sessionConfigCloneBasic() {
         SessionConfig original = new SessionConfig();
         original.setSessionId("my-session");
         original.setModel("gpt-4o");
         original.setStreaming(true);
-        
+
         SessionConfig cloned = original.clone();
-        
+
         assertEquals(original.getSessionId(), cloned.getSessionId());
         assertEquals(original.getModel(), cloned.getModel());
         assertEquals(original.isStreaming(), cloned.isStreaming());
@@ -66,25 +85,25 @@ void sessionConfigListIndependence() {
         toolList.add("grep");
         toolList.add("bash");
         original.setAvailableTools(toolList);
-        
+
         SessionConfig cloned = original.clone();
-        
-        List<String> clonedTools = new ArrayList<>(cloned.getAvailableTools());
-        clonedTools.add("web");
-        cloned.setAvailableTools(clonedTools);
-        
-        assertEquals(2, original.getAvailableTools().size());
-        assertEquals(3, cloned.getAvailableTools().size());
+
+        // Mutate the original list directly to test independence
+        toolList.add("web");
+
+        // The cloned config should be unaffected by mutations to the original list
+        assertEquals(2, cloned.getAvailableTools().size());
+        assertEquals(3, original.getAvailableTools().size());
     }
 
     @Test
     void resumeSessionConfigCloneBasic() {
         ResumeSessionConfig original = new ResumeSessionConfig();
         original.setModel("o1");
         original.setStreaming(false);
-        
+
         ResumeSessionConfig cloned = original.clone();
-        
+
         assertEquals(original.getModel(), cloned.getModel());
         assertEquals(original.isStreaming(), cloned.isStreaming());
     }
@@ -94,9 +113,9 @@ void messageOptionsCloneBasic() {
         MessageOptions original = new MessageOptions();
         original.setPrompt("What is 2+2?");
         original.setMode("immediate");
-        
+
         MessageOptions cloned = original.clone();
-        
+
         assertEquals(original.getPrompt(), cloned.getPrompt());
         assertEquals(original.getMode(), cloned.getMode());
     }
@@ -106,11 +125,11 @@ void clonePreservesNullFields() {
         CopilotClientOptions opts = new CopilotClientOptions();
         CopilotClientOptions optsClone = opts.clone();
         assertNull(optsClone.getCliPath());
-        
+
         SessionConfig cfg = new SessionConfig();
         SessionConfig cfgClone = cfg.clone();
         assertNull(cfgClone.getModel());
-        
+
         MessageOptions msg = new MessageOptions();
         MessageOptions msgClone = msg.clone();
         assertNull(msgClone.getMode());