Skip to content

Commit 034b244

Browse files
Fix Python type errors: remove stale PermissionDecision fields
PermissionDecision no longer has rules/feedback/message/path fields in the new permission vocabulary. Clean up PermissionRequestResult dataclass and client.py payload construction to match. Passes ty check, ruff lint, and all E2E tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2783bb2 commit 034b244

2 files changed

Lines changed: 1 addition & 18 deletions

File tree

python/copilot/client.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2725,16 +2725,7 @@ async def _handle_permission_request_v2(self, params: dict) -> dict:
27252725
result = await session._handle_permission_request(perm_request)
27262726
if result.kind == "no-result":
27272727
raise ValueError(NO_RESULT_PERMISSION_V2_ERROR)
2728-
result_payload: dict = {"kind": result.kind}
2729-
if result.rules is not None:
2730-
result_payload["rules"] = result.rules
2731-
if result.feedback is not None:
2732-
result_payload["feedback"] = result.feedback
2733-
if result.message is not None:
2734-
result_payload["message"] = result.message
2735-
if result.path is not None:
2736-
result_payload["path"] = result.path
2737-
return {"result": result_payload}
2728+
return {"result": {"kind": result.kind}}
27382729
except ValueError as exc:
27392730
if str(exc) == NO_RESULT_PERMISSION_V2_ERROR:
27402731
raise

python/copilot/session.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,6 @@ class PermissionRequestResult:
233233
"""Result of a permission request."""
234234

235235
kind: PermissionRequestResultKind = "user-not-available"
236-
rules: list[Any] | None = None
237-
feedback: str | None = None
238-
message: str | None = None
239-
path: str | None = None
240236

241237

242238
_PermissionHandlerFn = Callable[
@@ -1453,10 +1449,6 @@ async def _execute_permission_and_respond(
14531449

14541450
perm_result = PermissionDecision(
14551451
kind=PermissionDecisionKind(result.kind),
1456-
rules=result.rules,
1457-
feedback=result.feedback,
1458-
message=result.message,
1459-
path=result.path,
14601452
)
14611453

14621454
await self.rpc.permissions.handle_pending_permission_request(

0 commit comments

Comments
 (0)