Commit 10f0706
Address PR review comments from #1357
- Add missing RuntimeConnection imports to 26 test/scenarios TypeScript
fixtures. The earlier batch rewrite added the .forStdio/.forUri call
sites but missed the corresponding import statement, so each scenario
failed to compile until now.
- nodejs/test/e2e/harness/sdkTestContext.ts: strip the 'kind' property
before spreading a user-supplied RuntimeConnection back through the
forStdio/forTcp factory opts. The factory opt types don't accept
'kind' so the spread was producing excess-property type errors.
- nodejs/src/client.ts: rewrite the 'Path to Copilot CLI is required'
error message to point at the new connection options
(RuntimeConnection.forStdio({ path }), forTcp({ path }), forUri(...),
or the COPILOT_CLI_PATH environment variable). The old message
referenced removed cliPath / cliUrl options.
- nodejs/src/client.ts: change the default logLevel from 'debug' to
'info'. 'debug' was a TS-only outlier; Python and Rust default to
'info', and the README has always claimed 'info'. Go and .NET don't
pass --log-level at all when omitted (CLI defaults to info anyway),
so 'info' is consistent with every other SDK's effective default.
- nodejs/src/types.ts: fix MCPServerConfigBase.tools doc comment to
spell the all-tools sentinel as ['*'] (the actual type is string[],
so a bare '*' string can't be passed).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent bc0d2aa commit 10f0706
29 files changed
Lines changed: 42 additions & 34 deletions
File tree
- nodejs
- src
- test/e2e/harness
- test/scenarios
- auth
- byok-anthropic/typescript/src
- byok-azure/typescript/src
- byok-ollama/typescript/src
- byok-openai/typescript/src
- gh-app/typescript/src
- bundling/fully-bundled/typescript/src
- callbacks
- hooks/typescript/src
- permissions/typescript/src
- user-input/typescript/src
- modes
- default/typescript/src
- minimal/typescript/src
- prompts
- attachments/typescript/src
- reasoning-effort/typescript/src
- system-message/typescript/src
- sessions
- concurrent-sessions/typescript/src
- infinite-sessions/typescript/src
- session-resume/typescript/src
- streaming/typescript/src
- tools
- custom-agents/typescript/src
- mcp-servers/typescript/src
- no-tools/typescript/src
- skills/typescript/src
- tool-filtering/typescript/src
- tool-overrides/typescript/src
- virtual-filesystem/typescript/src
- transport/stdio/typescript/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
375 | 375 | | |
376 | 376 | | |
377 | 377 | | |
378 | | - | |
| 378 | + | |
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
| |||
1550 | 1550 | | |
1551 | 1551 | | |
1552 | 1552 | | |
1553 | | - | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
1554 | 1558 | | |
1555 | 1559 | | |
1556 | 1560 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1211 | 1211 | | |
1212 | 1212 | | |
1213 | 1213 | | |
1214 | | - | |
| 1214 | + | |
1215 | 1215 | | |
1216 | 1216 | | |
1217 | 1217 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
74 | 76 | | |
| 77 | + | |
75 | 78 | | |
76 | | - | |
77 | | - | |
| 79 | + | |
| 80 | + | |
78 | 81 | | |
79 | 82 | | |
| 83 | + | |
80 | 84 | | |
81 | | - | |
82 | | - | |
| 85 | + | |
| 86 | + | |
83 | 87 | | |
84 | 88 | | |
85 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
0 commit comments