Phase B fixup: regenerate codegen, fix scenario create_session calls

SteveSandersonMS · Copilot · SteveSandersonMS · commit 156029e7b271 · 2026-05-22T12:15:21.000+01:00
Two issues surfaced by Phase B CI: 1. The committed Python generated files were stale relative to the rest of the cross-language generators. Re-running `npm run generate` syncs them. No semantic change beyond round-tripping each variant dataclass through `from_dict(obj: Any) -> "Name":` quoting (matches what codegen has produced for a while; the on-disk file just hadn't been resynced). 2. `test/scenarios/**/python/main.py` were calling `client.create_session({...})` and `client.resume_session(session_id, {...})` with positional dicts. `CopilotClient.create_session` and `CopilotClient.resume_session` are kwargs-only — these always TypeError'd at runtime. Converted all 18 scenarios to explicit kwargs (`create_session(model="...", ...)`). Caught by github-code-quality CodeQL on PR #1376. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diff --git a/python/copilot/generated/rpc.py b/python/copilot/generated/rpc.py
diff --git a/python/copilot/generated/session_events.py b/python/copilot/generated/session_events.py
diff --git a/rust/src/generated/api_types.rs b/rust/src/generated/api_types.rs
@@ -10,7 +10,8 @@ use super::session_events::{
     AbortReason, McpServerSource, McpServerStatus, PermissionPromptRequest, PermissionRule,
     ReasoningSummary, SessionMode, ShutdownType, SkillSource, UserToolSessionApproval,
 };
-use crate::types::{RequestId, SessionEvent, SessionId};
+use crate::types::SessionEvent;
+use crate::types::{RequestId, SessionId};
 
 /// JSON-RPC method name constants.
 pub mod rpc_methods {
diff --git a/test/scenarios/auth/byok-anthropic/python/main.py b/test/scenarios/auth/byok-anthropic/python/main.py
@@ -18,19 +18,17 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": ANTHROPIC_MODEL,
-                "provider": {
-                    "type": "anthropic",
-                    "base_url": ANTHROPIC_BASE_URL,
-                    "api_key": ANTHROPIC_API_KEY,
-                },
-                "available_tools": [],
-                "system_message": {
-                    "mode": "replace",
-                    "content": "You are a helpful assistant. Answer concisely.",
-                },
-            }
+            model=ANTHROPIC_MODEL,
+            provider={
+                "type": "anthropic",
+                "base_url": ANTHROPIC_BASE_URL,
+                "api_key": ANTHROPIC_API_KEY,
+            },
+            available_tools=[],
+            system_message={
+                "mode": "replace",
+                "content": "You are a helpful assistant. Answer concisely.",
+            },
         )
 
         response = await session.send_and_wait("What is the capital of France?")
diff --git a/test/scenarios/auth/byok-azure/python/main.py b/test/scenarios/auth/byok-azure/python/main.py
@@ -19,22 +19,20 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": AZURE_OPENAI_MODEL,
-                "provider": {
-                    "type": "azure",
-                    "base_url": AZURE_OPENAI_ENDPOINT,
-                    "api_key": AZURE_OPENAI_API_KEY,
-                    "azure": {
-                        "api_version": AZURE_API_VERSION,
-                    },
+            model=AZURE_OPENAI_MODEL,
+            provider={
+                "type": "azure",
+                "base_url": AZURE_OPENAI_ENDPOINT,
+                "api_key": AZURE_OPENAI_API_KEY,
+                "azure": {
+                    "api_version": AZURE_API_VERSION,
                 },
-                "available_tools": [],
-                "system_message": {
-                    "mode": "replace",
-                    "content": "You are a helpful assistant. Answer concisely.",
-                },
-            }
+            },
+            available_tools=[],
+            system_message={
+                "mode": "replace",
+                "content": "You are a helpful assistant. Answer concisely.",
+            },
         )
 
         response = await session.send_and_wait("What is the capital of France?")
diff --git a/test/scenarios/auth/byok-ollama/python/main.py b/test/scenarios/auth/byok-ollama/python/main.py
@@ -16,18 +16,16 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": OLLAMA_MODEL,
-                "provider": {
-                    "type": "openai",
-                    "base_url": OLLAMA_BASE_URL,
-                },
-                "available_tools": [],
-                "system_message": {
-                    "mode": "replace",
-                    "content": COMPACT_SYSTEM_PROMPT,
-                },
-            }
+            model=OLLAMA_MODEL,
+            provider={
+                "type": "openai",
+                "base_url": OLLAMA_BASE_URL,
+            },
+            available_tools=[],
+            system_message={
+                "mode": "replace",
+                "content": COMPACT_SYSTEM_PROMPT,
+            },
         )
 
         response = await session.send_and_wait("What is the capital of France?")
diff --git a/test/scenarios/auth/byok-openai/python/main.py b/test/scenarios/auth/byok-openai/python/main.py
@@ -18,14 +18,12 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": OPENAI_MODEL,
-                "provider": {
-                    "type": "openai",
-                    "base_url": OPENAI_BASE_URL,
-                    "api_key": OPENAI_API_KEY,
-                },
-            }
+            model=OPENAI_MODEL,
+            provider={
+                "type": "openai",
+                "base_url": OPENAI_BASE_URL,
+                "api_key": OPENAI_API_KEY,
+            },
         )
 
         response = await session.send_and_wait("What is the capital of France?")
diff --git a/test/scenarios/auth/gh-app/python/main.py b/test/scenarios/auth/gh-app/python/main.py
@@ -82,7 +82,7 @@ async def main():
     client = CopilotClient(CopilotClientOptions(github_token=token))
 
     try:
-        session = await client.create_session({"model": "claude-haiku-4.5"})
+        session = await client.create_session(model="claude-haiku-4.5")
         response = await session.send_and_wait("What is the capital of France?")
         if response:
             print(response.data.content)
diff --git a/test/scenarios/bundling/app-backend-to-server/python/main.py b/test/scenarios/bundling/app-backend-to-server/python/main.py
@@ -17,7 +17,7 @@ async def ask_copilot(prompt: str) -> str:
     client = CopilotClient(CopilotClientOptions(connection=RuntimeConnection.uri(CLI_URL)))
 
     try:
-        session = await client.create_session({"model": "claude-haiku-4.5"})
+        session = await client.create_session(model="claude-haiku-4.5")
 
         response = await session.send_and_wait(prompt)
 
diff --git a/test/scenarios/bundling/app-direct-server/python/main.py b/test/scenarios/bundling/app-direct-server/python/main.py
@@ -14,7 +14,7 @@ async def main():
     )
 
     try:
-        session = await client.create_session({"model": "claude-haiku-4.5"})
+        session = await client.create_session(model="claude-haiku-4.5")
 
         response = await session.send_and_wait("What is the capital of France?")
 
diff --git a/test/scenarios/bundling/container-proxy/python/main.py b/test/scenarios/bundling/container-proxy/python/main.py
@@ -14,7 +14,7 @@ async def main():
     )
 
     try:
-        session = await client.create_session({"model": "claude-haiku-4.5"})
+        session = await client.create_session(model="claude-haiku-4.5")
 
         response = await session.send_and_wait("What is the capital of France?")
 
diff --git a/test/scenarios/bundling/fully-bundled/python/main.py b/test/scenarios/bundling/fully-bundled/python/main.py
@@ -12,7 +12,7 @@ async def main():
     )
 
     try:
-        session = await client.create_session({"model": "claude-haiku-4.5"})
+        session = await client.create_session(model="claude-haiku-4.5")
 
         response = await session.send_and_wait("What is the capital of France?")
 
diff --git a/test/scenarios/callbacks/hooks/python/main.py b/test/scenarios/callbacks/hooks/python/main.py
@@ -49,18 +49,16 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "on_permission_request": auto_approve_permission,
-                "hooks": {
-                    "on_session_start": on_session_start,
-                    "on_session_end": on_session_end,
-                    "on_pre_tool_use": on_pre_tool_use,
-                    "on_post_tool_use": on_post_tool_use,
-                    "on_user_prompt_submitted": on_user_prompt_submitted,
-                    "on_error_occurred": on_error_occurred,
-                },
-            }
+            model="claude-haiku-4.5",
+            on_permission_request=auto_approve_permission,
+            hooks={
+                "on_session_start": on_session_start,
+                "on_session_end": on_session_end,
+                "on_pre_tool_use": on_pre_tool_use,
+                "on_post_tool_use": on_post_tool_use,
+                "on_user_prompt_submitted": on_user_prompt_submitted,
+                "on_error_occurred": on_error_occurred,
+            },
         )
 
         response = await session.send_and_wait(
diff --git a/test/scenarios/callbacks/permissions/python/main.py b/test/scenarios/callbacks/permissions/python/main.py
@@ -26,11 +26,9 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "on_permission_request": log_permission,
-                "hooks": {"on_pre_tool_use": auto_approve_tool},
-            }
+            model="claude-haiku-4.5",
+            on_permission_request=log_permission,
+            hooks={"on_pre_tool_use": auto_approve_tool},
         )
 
         response = await session.send_and_wait(
diff --git a/test/scenarios/callbacks/user-input/python/main.py b/test/scenarios/callbacks/user-input/python/main.py
@@ -29,12 +29,10 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "on_permission_request": auto_approve_permission,
-                "on_user_input_request": handle_user_input,
-                "hooks": {"on_pre_tool_use": auto_approve_tool},
-            }
+            model="claude-haiku-4.5",
+            on_permission_request=auto_approve_permission,
+            on_user_input_request=handle_user_input,
+            hooks={"on_pre_tool_use": auto_approve_tool},
         )
 
         response = await session.send_and_wait(
diff --git a/test/scenarios/modes/default/python/main.py b/test/scenarios/modes/default/python/main.py
@@ -12,11 +12,7 @@ async def main():
     )
 
     try:
-        session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-            }
-        )
+        session = await client.create_session(model="claude-haiku-4.5")
 
         response = await session.send_and_wait(
             "Use the grep tool to search for the word 'SDK' in README.md and show the matching lines."
diff --git a/test/scenarios/modes/minimal/python/main.py b/test/scenarios/modes/minimal/python/main.py
@@ -13,14 +13,12 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "available_tools": [],
-                "system_message": {
-                    "mode": "replace",
-                    "content": "You have no tools. Respond with text only.",
-                },
-            }
+            model="claude-haiku-4.5",
+            available_tools=[],
+            system_message={
+                "mode": "replace",
+                "content": "You have no tools. Respond with text only.",
+            },
         )
 
         response = await session.send_and_wait(
diff --git a/test/scenarios/prompts/attachments/python/main.py b/test/scenarios/prompts/attachments/python/main.py
@@ -15,11 +15,9 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "system_message": {"mode": "replace", "content": SYSTEM_PROMPT},
-                "available_tools": [],
-            }
+            model="claude-haiku-4.5",
+            system_message={"mode": "replace", "content": SYSTEM_PROMPT},
+            available_tools=[],
         )
 
         sample_file = os.path.join(os.path.dirname(__file__), "..", "sample-data.txt")
diff --git a/test/scenarios/prompts/reasoning-effort/python/main.py b/test/scenarios/prompts/reasoning-effort/python/main.py
@@ -13,15 +13,13 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-opus-4.6",
-                "reasoning_effort": "low",
-                "available_tools": [],
-                "system_message": {
-                    "mode": "replace",
-                    "content": "You are a helpful assistant. Answer concisely.",
-                },
-            }
+            model="claude-opus-4.6",
+            reasoning_effort="low",
+            available_tools=[],
+            system_message={
+                "mode": "replace",
+                "content": "You are a helpful assistant. Answer concisely.",
+            },
         )
 
         response = await session.send_and_wait("What is the capital of France?")
diff --git a/test/scenarios/prompts/system-message/python/main.py b/test/scenarios/prompts/system-message/python/main.py
@@ -15,11 +15,9 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "system_message": {"mode": "replace", "content": PIRATE_PROMPT},
-                "available_tools": [],
-            }
+            model="claude-haiku-4.5",
+            system_message={"mode": "replace", "content": PIRATE_PROMPT},
+            available_tools=[],
         )
 
         response = await session.send_and_wait("What is the capital of France?")
diff --git a/test/scenarios/sessions/concurrent-sessions/python/main.py b/test/scenarios/sessions/concurrent-sessions/python/main.py
@@ -17,18 +17,14 @@ async def main():
     try:
         session1, session2 = await asyncio.gather(
             client.create_session(
-                {
-                    "model": "claude-haiku-4.5",
-                    "system_message": {"mode": "replace", "content": PIRATE_PROMPT},
-                    "available_tools": [],
-                }
+                model="claude-haiku-4.5",
+                system_message={"mode": "replace", "content": PIRATE_PROMPT},
+                available_tools=[],
             ),
             client.create_session(
-                {
-                    "model": "claude-haiku-4.5",
-                    "system_message": {"mode": "replace", "content": ROBOT_PROMPT},
-                    "available_tools": [],
-                }
+                model="claude-haiku-4.5",
+                system_message={"mode": "replace", "content": ROBOT_PROMPT},
+                available_tools=[],
             ),
         )
 
diff --git a/test/scenarios/sessions/infinite-sessions/python/main.py b/test/scenarios/sessions/infinite-sessions/python/main.py
@@ -13,19 +13,17 @@ async def main():
 
     try:
         session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "available_tools": [],
-                "system_message": {
-                    "mode": "replace",
-                    "content": "You are a helpful assistant. Answer concisely in one sentence.",
-                },
-                "infinite_sessions": {
-                    "enabled": True,
-                    "background_compaction_threshold": 0.80,
-                    "buffer_exhaustion_threshold": 0.95,
-                },
-            }
+            model="claude-haiku-4.5",
+            available_tools=[],
+            system_message={
+                "mode": "replace",
+                "content": "You are a helpful assistant. Answer concisely in one sentence.",
+            },
+            infinite_sessions={
+                "enabled": True,
+                "background_compaction_threshold": 0.80,
+                "buffer_exhaustion_threshold": 0.95,
+            },
         )
 
         prompts = [
diff --git a/test/scenarios/sessions/session-resume/python/main.py b/test/scenarios/sessions/session-resume/python/main.py
@@ -13,12 +13,7 @@ async def main():
 
     try:
         # 1. Create a session
-        session = await client.create_session(
-            {
-                "model": "claude-haiku-4.5",
-                "available_tools": [],
-            }
-        )
+        session = await client.create_session(model="claude-haiku-4.5", available_tools=[])
 
         # 2. Send the secret word
         await session.send_and_wait("Remember this: the secret word is PINEAPPLE.")
diff --git a/test/scenarios/sessions/streaming/python/main.py b/test/scenarios/sessions/streaming/python/main.py
diff --git a/test/scenarios/tools/no-tools/python/main.py b/test/scenarios/tools/no-tools/python/main.py
diff --git a/test/scenarios/tools/tool-filtering/python/main.py b/test/scenarios/tools/tool-filtering/python/main.py
diff --git a/test/scenarios/transport/reconnect/python/main.py b/test/scenarios/transport/reconnect/python/main.py
diff --git a/test/scenarios/transport/stdio/python/main.py b/test/scenarios/transport/stdio/python/main.py
diff --git a/test/scenarios/transport/tcp/python/main.py b/test/scenarios/transport/tcp/python/main.py

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ async def main():`
`14`	`14`	`)`
`15`	`15`
`16`	`16`	`try:`
`17`		`- session = await client.create_session({"model": "claude-haiku-4.5"})`
	`17`	`+ session = await client.create_session(model="claude-haiku-4.5")`
`18`	`18`
`19`	`19`	`response = await session.send_and_wait("What is the capital of France?")`
`20`	`20`