Skip to content

Commit 1e90676

Browse files
Rename experimental mode session option across SDKs
Co-authored-by: SteveSandersonMS <1101362+SteveSandersonMS@users.noreply.github.com>
1 parent c70d1da commit 1e90676

17 files changed

Lines changed: 96 additions & 100 deletions

File tree

dotnet/src/Client.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ public async Task<CopilotSession> CreateSessionAsync(SessionConfig config, Cance
896896
toolFilter.ExcludedTools,
897897
config.Provider,
898898
config.EnableSessionTelemetry,
899-
config.IsExperimentalMode,
899+
config.EnableExperimentalMode,
900900
config.OnPermissionRequest != null ? true : null,
901901
config.OnUserInputRequest != null ? true : null,
902902
config.OnExitPlanModeRequest != null ? true : null,
@@ -1092,7 +1092,7 @@ public async Task<CopilotSession> ResumeSessionAsync(string sessionId, ResumeSes
10921092
toolFilter.ExcludedTools,
10931093
config.Provider,
10941094
config.EnableSessionTelemetry,
1095-
config.IsExperimentalMode,
1095+
config.EnableExperimentalMode,
10961096
config.OnPermissionRequest != null ? true : null,
10971097
config.OnUserInputRequest != null ? true : null,
10981098
config.OnExitPlanModeRequest != null ? true : null,

dotnet/src/Types.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2474,7 +2474,7 @@ protected SessionConfigBase(SessionConfigBase? other)
24742474
OnUserInputRequest = other.OnUserInputRequest;
24752475
Provider = other.Provider;
24762476
EnableSessionTelemetry = other.EnableSessionTelemetry;
2477-
IsExperimentalMode = other.IsExperimentalMode;
2477+
EnableExperimentalMode = other.EnableExperimentalMode;
24782478
SkipCustomInstructions = other.SkipCustomInstructions;
24792479
CustomAgentsLocalOnly = other.CustomAgentsLocalOnly;
24802480
CoauthorEnabled = other.CoauthorEnabled;
@@ -2649,7 +2649,7 @@ protected SessionConfigBase(SessionConfigBase? other)
26492649
/// experimental were off. Leave <see langword="null"/> to inherit the runtime
26502650
/// process defaults unchanged.
26512651
/// </remarks>
2652-
public bool? IsExperimentalMode { get; set; }
2652+
public bool? EnableExperimentalMode { get; set; }
26532653

26542654
/// <summary>
26552655
/// When <see langword="true"/>, suppresses loading of custom instruction files

dotnet/test/Unit/CloneTests.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void SessionConfig_Clone_CopiesAllProperties()
7676
WorkingDirectory = "/workspace",
7777
Streaming = true,
7878
EnableSessionTelemetry = false,
79-
IsExperimentalMode = true,
79+
EnableExperimentalMode = true,
8080
EnableOnDemandInstructionDiscovery = true,
8181
IncludeSubAgentStreamingEvents = false,
8282
McpServers = new Dictionary<string, McpServerConfig> { ["server1"] = new McpStdioServerConfig { Command = "echo" } },
@@ -116,7 +116,7 @@ public void SessionConfig_Clone_CopiesAllProperties()
116116
Assert.Equal(original.WorkingDirectory, clone.WorkingDirectory);
117117
Assert.Equal(original.Streaming, clone.Streaming);
118118
Assert.Equal(original.EnableSessionTelemetry, clone.EnableSessionTelemetry);
119-
Assert.Equal(original.IsExperimentalMode, clone.IsExperimentalMode);
119+
Assert.Equal(original.EnableExperimentalMode, clone.EnableExperimentalMode);
120120
Assert.Equal(original.EnableOnDemandInstructionDiscovery, clone.EnableOnDemandInstructionDiscovery);
121121
Assert.Equal(original.IncludeSubAgentStreamingEvents, clone.IncludeSubAgentStreamingEvents);
122122
Assert.Equal(original.McpServers.Count, clone.McpServers!.Count);
@@ -358,16 +358,16 @@ public void ResumeSessionConfig_Clone_CopiesEnableSessionTelemetry()
358358
}
359359

360360
[Fact]
361-
public void ResumeSessionConfig_Clone_CopiesIsExperimentalMode()
361+
public void ResumeSessionConfig_Clone_CopiesEnableExperimentalMode()
362362
{
363363
var original = new ResumeSessionConfig
364364
{
365-
IsExperimentalMode = true,
365+
EnableExperimentalMode = true,
366366
};
367367

368368
var clone = original.Clone();
369369

370-
Assert.True(clone.IsExperimentalMode);
370+
Assert.True(clone.EnableExperimentalMode);
371371
}
372372

373373
[Fact]
@@ -456,23 +456,23 @@ public void ResumeSessionConfig_Clone_PreservesEnableSessionTelemetryDefault()
456456
}
457457

458458
[Fact]
459-
public void SessionConfig_Clone_PreservesIsExperimentalModeDefault()
459+
public void SessionConfig_Clone_PreservesEnableExperimentalModeDefault()
460460
{
461461
var original = new SessionConfig();
462462

463463
var clone = original.Clone();
464464

465-
Assert.Null(clone.IsExperimentalMode);
465+
Assert.Null(clone.EnableExperimentalMode);
466466
}
467467

468468
[Fact]
469-
public void ResumeSessionConfig_Clone_PreservesIsExperimentalModeDefault()
469+
public void ResumeSessionConfig_Clone_PreservesEnableExperimentalModeDefault()
470470
{
471471
var original = new ResumeSessionConfig();
472472

473473
var clone = original.Clone();
474474

475-
Assert.Null(clone.IsExperimentalMode);
475+
Assert.Null(clone.EnableExperimentalMode);
476476
}
477477

478478
[Fact]

dotnet/test/Unit/SerializationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ public void ResumeSessionRequest_CanSerializeEnableSessionTelemetry_WithSdkOptio
300300
}
301301

302302
[Fact]
303-
public void SessionRequests_CanSerializeIsExperimentalMode_WithSdkOptions()
303+
public void SessionRequests_CanSerializeEnableExperimentalMode_WithSdkOptions()
304304
{
305305
var options = GetSerializerOptions();
306306

go/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@ func (c *Client) CreateSession(ctx context.Context, config *SessionConfig) (*Ses
629629
req.ToolFilterPrecedence = precedence
630630
req.Provider = config.Provider
631631
req.EnableSessionTelemetry = config.EnableSessionTelemetry
632-
req.IsExperimentalMode = config.IsExperimentalMode
632+
req.IsExperimentalMode = config.EnableExperimentalMode
633633
req.SkipCustomInstructions = config.SkipCustomInstructions
634634
req.CustomAgentsLocalOnly = config.CustomAgentsLocalOnly
635635
req.CoauthorEnabled = config.CoauthorEnabled
@@ -924,7 +924,7 @@ func (c *Client) ResumeSessionWithOptions(ctx context.Context, sessionID string,
924924
req.Tools = config.Tools
925925
req.Provider = config.Provider
926926
req.EnableSessionTelemetry = config.EnableSessionTelemetry
927-
req.IsExperimentalMode = config.IsExperimentalMode
927+
req.IsExperimentalMode = config.EnableExperimentalMode
928928
req.SkipCustomInstructions = config.SkipCustomInstructions
929929
req.CustomAgentsLocalOnly = config.CustomAgentsLocalOnly
930930
req.CoauthorEnabled = config.CoauthorEnabled

go/client_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1242,8 +1242,8 @@ func TestCreateSessionRequest_RequestMCPApps(t *testing.T) {
12421242
})
12431243
}
12441244

1245-
func TestSessionRequests_IsExperimentalMode(t *testing.T) {
1246-
t.Run("create forwards isExperimentalMode when explicitly false", func(t *testing.T) {
1245+
func TestSessionRequests_EnableExperimentalMode(t *testing.T) {
1246+
t.Run("create forwards enableExperimentalMode when explicitly false", func(t *testing.T) {
12471247
req := createSessionRequest{
12481248
IsExperimentalMode: Bool(false),
12491249
}
@@ -1260,7 +1260,7 @@ func TestSessionRequests_IsExperimentalMode(t *testing.T) {
12601260
}
12611261
})
12621262

1263-
t.Run("create omits isExperimentalMode when unset", func(t *testing.T) {
1263+
t.Run("create omits enableExperimentalMode when unset", func(t *testing.T) {
12641264
req := createSessionRequest{}
12651265
data, _ := json.Marshal(req)
12661266
var m map[string]any
@@ -1270,7 +1270,7 @@ func TestSessionRequests_IsExperimentalMode(t *testing.T) {
12701270
}
12711271
})
12721272

1273-
t.Run("resume forwards isExperimentalMode when explicitly true", func(t *testing.T) {
1273+
t.Run("resume forwards enableExperimentalMode when explicitly true", func(t *testing.T) {
12741274
req := resumeSessionRequest{
12751275
SessionID: "s1",
12761276
IsExperimentalMode: Bool(true),
@@ -1288,7 +1288,7 @@ func TestSessionRequests_IsExperimentalMode(t *testing.T) {
12881288
}
12891289
})
12901290

1291-
t.Run("resume omits isExperimentalMode when unset", func(t *testing.T) {
1291+
t.Run("resume omits enableExperimentalMode when unset", func(t *testing.T) {
12921292
req := resumeSessionRequest{SessionID: "s1"}
12931293
data, _ := json.Marshal(req)
12941294
var m map[string]any

go/types.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -980,12 +980,12 @@ type SessionConfig struct {
980980
// regardless of this setting. This is independent of the OpenTelemetry
981981
// configuration in ClientOptions.Telemetry.
982982
EnableSessionTelemetry *bool
983-
// IsExperimentalMode, when non-nil, overrides the session's experimental
983+
// EnableExperimentalMode, when non-nil, overrides the session's experimental
984984
// feature-flag tier resolution. Use Bool(true) to force-enable the
985985
// experimental tier for this session, Bool(false) to resolve feature flags
986986
// as if experimental were off, or nil to inherit the runtime process
987987
// defaults unchanged.
988-
IsExperimentalMode *bool
988+
EnableExperimentalMode *bool
989989
// SkipCustomInstructions, when non-nil, controls whether the runtime loads
990990
// custom instruction files. See also [ClientOptions.Mode] = [ModeEmpty].
991991
SkipCustomInstructions *bool
@@ -1301,12 +1301,12 @@ type ResumeSessionConfig struct {
13011301
// regardless of this setting. This is independent of the OpenTelemetry
13021302
// configuration in ClientOptions.Telemetry.
13031303
EnableSessionTelemetry *bool
1304-
// IsExperimentalMode, when non-nil, overrides the resumed session's
1304+
// EnableExperimentalMode, when non-nil, overrides the resumed session's
13051305
// experimental feature-flag tier resolution. Use Bool(true) to force-enable
13061306
// the experimental tier for this session, Bool(false) to resolve feature
13071307
// flags as if experimental were off, or nil to inherit the runtime process
13081308
// defaults unchanged.
1309-
IsExperimentalMode *bool
1309+
EnableExperimentalMode *bool
13101310
// SkipCustomInstructions, when non-nil, controls whether the runtime loads
13111311
// custom instruction files. See also [ClientOptions.Mode] = [ModeEmpty].
13121312
SkipCustomInstructions *bool

java/src/main/java/com/github/copilot/SessionRequestBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ static CreateSessionRequest buildCreateRequest(SessionConfig config, String sess
114114
request.setExcludedTools(config.getExcludedTools());
115115
request.setProvider(config.getProvider());
116116
config.getEnableSessionTelemetry().ifPresent(request::setEnableSessionTelemetry);
117-
config.getIsExperimentalMode().ifPresent(request::setIsExperimentalMode);
117+
config.getEnableExperimentalMode().ifPresent(request::setIsExperimentalMode);
118118
if (config.getOnUserInputRequest() != null) {
119119
request.setRequestUserInput(true);
120120
}
@@ -226,7 +226,7 @@ static ResumeSessionRequest buildResumeRequest(String sessionId, ResumeSessionCo
226226
request.setExcludedTools(config.getExcludedTools());
227227
request.setProvider(config.getProvider());
228228
config.getEnableSessionTelemetry().ifPresent(request::setEnableSessionTelemetry);
229-
config.getIsExperimentalMode().ifPresent(request::setIsExperimentalMode);
229+
config.getEnableExperimentalMode().ifPresent(request::setIsExperimentalMode);
230230
if (config.getOnUserInputRequest() != null) {
231231
request.setRequestUserInput(true);
232232
}

java/src/main/java/com/github/copilot/rpc/ResumeSessionConfig.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public class ResumeSessionConfig {
4646
private List<String> excludedTools;
4747
private ProviderConfig provider;
4848
private Boolean enableSessionTelemetry;
49-
private Boolean isExperimentalMode;
49+
private Boolean enableExperimentalMode;
5050
private Boolean skipCustomInstructions;
5151
private Boolean customAgentsLocalOnly;
5252
private Boolean coauthorEnabled;
@@ -306,32 +306,32 @@ public ResumeSessionConfig clearEnableSessionTelemetry() {
306306
* inherit the runtime process defaults unchanged
307307
*/
308308
@JsonIgnore
309-
public Optional<Boolean> getIsExperimentalMode() {
310-
return Optional.ofNullable(isExperimentalMode);
309+
public Optional<Boolean> getEnableExperimentalMode() {
310+
return Optional.ofNullable(enableExperimentalMode);
311311
}
312312

313313
/**
314314
* Overrides the resumed session's experimental feature-flag tier resolution.
315315
*
316-
* @param isExperimentalMode
316+
* @param enableExperimentalMode
317317
* {@code true} to force-enable the experimental tier for this
318318
* session, {@code false} to resolve feature flags as if experimental
319319
* were off
320320
* @return this config for method chaining
321321
*/
322-
public ResumeSessionConfig setIsExperimentalMode(boolean isExperimentalMode) {
323-
this.isExperimentalMode = isExperimentalMode;
322+
public ResumeSessionConfig setEnableExperimentalMode(boolean enableExperimentalMode) {
323+
this.enableExperimentalMode = enableExperimentalMode;
324324
return this;
325325
}
326326

327327
/**
328-
* Clears the isExperimentalMode setting, reverting to the runtime default
328+
* Clears the enableExperimentalMode setting, reverting to the runtime default
329329
* behavior.
330330
*
331331
* @return this instance for method chaining
332332
*/
333-
public ResumeSessionConfig clearIsExperimentalMode() {
334-
this.isExperimentalMode = null;
333+
public ResumeSessionConfig clearEnableExperimentalMode() {
334+
this.enableExperimentalMode = null;
335335
return this;
336336
}
337337

@@ -1565,7 +1565,7 @@ public ResumeSessionConfig clone() {
15651565
copy.excludedTools = this.excludedTools != null ? new ArrayList<>(this.excludedTools) : null;
15661566
copy.provider = this.provider;
15671567
copy.enableSessionTelemetry = this.enableSessionTelemetry;
1568-
copy.isExperimentalMode = this.isExperimentalMode;
1568+
copy.enableExperimentalMode = this.enableExperimentalMode;
15691569
copy.reasoningEffort = this.reasoningEffort;
15701570
copy.reasoningSummary = this.reasoningSummary;
15711571
copy.contextTier = this.contextTier;

java/src/main/java/com/github/copilot/rpc/SessionConfig.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public class SessionConfig {
5050
private List<String> excludedTools;
5151
private ProviderConfig provider;
5252
private Boolean enableSessionTelemetry;
53-
private Boolean isExperimentalMode;
53+
private Boolean enableExperimentalMode;
5454
private Boolean skipCustomInstructions;
5555
private Boolean customAgentsLocalOnly;
5656
private Boolean coauthorEnabled;
@@ -407,32 +407,32 @@ public SessionConfig clearEnableSessionTelemetry() {
407407
* inherit the runtime process defaults unchanged
408408
*/
409409
@JsonIgnore
410-
public Optional<Boolean> getIsExperimentalMode() {
411-
return Optional.ofNullable(isExperimentalMode);
410+
public Optional<Boolean> getEnableExperimentalMode() {
411+
return Optional.ofNullable(enableExperimentalMode);
412412
}
413413

414414
/**
415415
* Overrides the session's experimental feature-flag tier resolution.
416416
*
417-
* @param isExperimentalMode
417+
* @param enableExperimentalMode
418418
* {@code true} to force-enable the experimental tier for this
419419
* session, {@code false} to resolve feature flags as if experimental
420420
* were off
421421
* @return this config instance for method chaining
422422
*/
423-
public SessionConfig setIsExperimentalMode(boolean isExperimentalMode) {
424-
this.isExperimentalMode = isExperimentalMode;
423+
public SessionConfig setEnableExperimentalMode(boolean enableExperimentalMode) {
424+
this.enableExperimentalMode = enableExperimentalMode;
425425
return this;
426426
}
427427

428428
/**
429-
* Clears the isExperimentalMode setting, reverting to the runtime default
429+
* Clears the enableExperimentalMode setting, reverting to the runtime default
430430
* behavior.
431431
*
432432
* @return this instance for method chaining
433433
*/
434-
public SessionConfig clearIsExperimentalMode() {
435-
this.isExperimentalMode = null;
434+
public SessionConfig clearEnableExperimentalMode() {
435+
this.enableExperimentalMode = null;
436436
return this;
437437
}
438438

@@ -1688,7 +1688,7 @@ public SessionConfig clone() {
16881688
copy.excludedTools = this.excludedTools != null ? new ArrayList<>(this.excludedTools) : null;
16891689
copy.provider = this.provider;
16901690
copy.enableSessionTelemetry = this.enableSessionTelemetry;
1691-
copy.isExperimentalMode = this.isExperimentalMode;
1691+
copy.enableExperimentalMode = this.enableExperimentalMode;
16921692
copy.skipCustomInstructions = this.skipCustomInstructions;
16931693
copy.customAgentsLocalOnly = this.customAgentsLocalOnly;
16941694
copy.coauthorEnabled = this.coauthorEnabled;

0 commit comments

Comments
 (0)