Skip to content

Commit 23ecff3

Browse files
Fix permission test race: client 2 handler never resolves so only client 1 approves
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent e280f87 commit 23ecff3

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

nodejs/test/e2e/multi-client.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ describe("Multi-client broadcast", async () => {
9494
},
9595
});
9696

97-
// Client 2 resumes the same session — no permission handler needed,
98-
// it just observes the broadcast events
97+
// Client 2 resumes the same session — its handler never resolves,
98+
// so only client 1's approval takes effect (no race)
9999
const session2 = await client2.resumeSession(session1.sessionId, {
100-
onPermissionRequest: approveAll,
100+
onPermissionRequest: () => new Promise(() => {}),
101101
});
102102

103103
// Track events seen by each client

0 commit comments

Comments
 (0)