Fix test failures

Author: edburns

.github/skills/java-coding-skill/SKILL.md

@@ -1,17 +1,17 @@
 ---
 name: java-coding-skill
-description: "Use this skill whenever editing `*.java` files in the `java/` SDK in order to write idiomatic, well-structured Java code for the Copilot SDK"
+description: "Use this skill whenever editing `*.java` files in the `java/` directore of the SDK in order to write idiomatic, well-structured Java code for the Copilot SDK"
 ---
 
 # Java Coding Skill
 
 ## Core Principles
 
-- The SDK is in public preview and may have breaking changes
-- Requires Java 17 or later
-- Requires GitHub Copilot CLI installed and in PATH
-- Uses `CompletableFuture` for all async operations
-- Implements `AutoCloseable` for resource cleanup (try-with-resources)
+- Requires Java 25 or later for building the jar artifact for Copilot SDK for java.
+- Uses the Multi-Relase jar feature JEP 238 https://openjdk.org/jeps/238 with `maven.compiler.release` 17 so that uses running JDK 17 can use the jar.
+- Requires GitHub Copilot CLI installed and in PATH.
+- Uses `CompletableFuture` for all async operations.
+- Implements `AutoCloseable` for resource cleanup (try-with-resources).
 
 ## Installation
 

java/pom.xml

@@ -163,6 +163,26 @@
             </plugins>
         </pluginManagement>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-clean-plugin</artifactId>
+                <version>3.4.1</version>
+                <configuration>
+                    <!--
+                        The E2E test harness spawns Node.js child processes
+                        (npx tsx server.ts) whose CWD is inside
+                        target/copilot-sdk/test/harness/. On macOS, orphaned
+                        node processes can briefly hold file descriptors on
+                        the directory tree after the test JVM exits, causing
+                        the first 'mvn clean' to fail with
+                        "Failed to delete target/copilot-sdk".
+
+                        retryOnError + retryCount give the OS time to reap
+                        those processes before the clean phase gives up.
+                    -->
+                    <retryOnError>true</retryOnError>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>

java/src/main/java/module-info.java

@@ -22,5 +22,6 @@
 
     opens com.github.copilot to com.fasterxml.jackson.databind;
     opens com.github.copilot.generated to com.fasterxml.jackson.databind;
+    opens com.github.copilot.generated.rpc to com.fasterxml.jackson.databind;
     opens com.github.copilot.rpc to com.fasterxml.jackson.databind;
 }