fix: regenerate stale hook snapshots for updated runtime

Author: SteveSandersonMS

dotnet/test/HooksTests.cs

@@ -46,8 +46,7 @@ await session.SendAsync(new MessageOptions
         Assert.Contains(preToolUseInputs, i => !string.IsNullOrEmpty(i.ToolName));
     }
 
-    // TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
-    [Fact(Skip = "Runtime postToolUse hooks broken")]
+    [Fact]
     public async Task Should_Invoke_PostToolUse_Hook_After_Model_Runs_A_Tool()
     {
         var postToolUseInputs = new List<PostToolUseHookInput>();
@@ -84,8 +83,7 @@ await session.SendAsync(new MessageOptions
         Assert.Contains(postToolUseInputs, i => i.ToolResult != null);
     }
 
-    // TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
-    [Fact(Skip = "Runtime postToolUse hooks broken")]
+    [Fact]
     public async Task Should_Invoke_Both_PreToolUse_And_PostToolUse_Hooks_For_Single_Tool_Call()
     {
         var preToolUseInputs = new List<PreToolUseHookInput>();

go/internal/e2e/hooks_test.go

@@ -74,9 +74,7 @@ func TestHooks(t *testing.T) {
 		}
 	})
 
-	// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
 	t.Run("should invoke postToolUse hook after model runs a tool", func(t *testing.T) {
-		t.Skip("Runtime postToolUse hooks broken")
 		ctx.ConfigureForTest(t)
 
 		var postToolUseInputs []copilot.PostToolUseHookInput
@@ -141,9 +139,7 @@ func TestHooks(t *testing.T) {
 		}
 	})
 
-	// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
 	t.Run("should invoke both preToolUse and postToolUse hooks for a single tool call", func(t *testing.T) {
-		t.Skip("Runtime postToolUse hooks broken")
 		ctx.ConfigureForTest(t)
 
 		var preToolUseInputs []copilot.PreToolUseHookInput

nodejs/test/e2e/hooks.test.ts

@@ -48,8 +48,7 @@ describe("Session hooks", async () => {
         await session.disconnect();
     });
 
-    // TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
-    it.skip("should invoke postToolUse hook after model runs a tool", async () => {
+    it("should invoke postToolUse hook after model runs a tool", async () => {
         const postToolUseInputs: PostToolUseHookInput[] = [];
 
         const session = await client.createSession({
@@ -80,8 +79,7 @@ describe("Session hooks", async () => {
         await session.disconnect();
     });
 
-    // TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
-    it.skip("should invoke both preToolUse and postToolUse hooks for a single tool call", async () => {
+    it("should invoke both preToolUse and postToolUse hooks for a single tool call", async () => {
         const preToolUseInputs: PreToolUseHookInput[] = [];
         const postToolUseInputs: PostToolUseHookInput[] = [];
 

python/e2e/test_hooks.py

@@ -41,8 +41,6 @@ async def on_pre_tool_use(input_data, invocation):
 
         await session.disconnect()
 
-    # TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
-    @pytest.mark.skip(reason="Runtime postToolUse hooks broken")
     async def test_should_invoke_posttooluse_hook_after_model_runs_a_tool(
         self, ctx: E2ETestContext
     ):
@@ -73,8 +71,6 @@ async def on_post_tool_use(input_data, invocation):
 
         await session.disconnect()
 
-    # TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
-    @pytest.mark.skip(reason="Runtime postToolUse hooks broken")
     async def test_should_invoke_both_pretooluse_and_posttooluse_hooks_for_a_single_tool_call(
         self, ctx: E2ETestContext
     ):

test/snapshots/hooks/invoke_both_hooks_for_single_tool_call.yaml

@@ -6,6 +6,8 @@ conversations:
         content: ${system}
       - role: user
         content: Read the contents of both.txt
+      - role: assistant
+        content: I'll read the contents of both.txt for you.
       - role: assistant
         tool_calls:
           - id: toolcall_0
@@ -26,6 +28,7 @@ conversations:
       - role: user
         content: Read the contents of both.txt
       - role: assistant
+        content: I'll read the contents of both.txt for you.
         tool_calls:
           - id: toolcall_0
             type: function
@@ -44,4 +47,8 @@ conversations:
         tool_call_id: toolcall_1
         content: 1. Testing both hooks!
       - role: assistant
-        content: 'The file contains a single line: "Testing both hooks!"'
+        content: |-
+          The file `both.txt` contains a single line:
+          ```
+          Testing both hooks!
+          ```

test/snapshots/hooks/invoke_post_tool_use_hook_after_model_runs_a_tool.yaml

@@ -6,6 +6,8 @@ conversations:
         content: ${system}
       - role: user
         content: Read the contents of world.txt and tell me what it says
+      - role: assistant
+        content: I'll read the contents of world.txt for you.
       - role: assistant
         tool_calls:
           - id: toolcall_0
@@ -26,6 +28,7 @@ conversations:
       - role: user
         content: Read the contents of world.txt and tell me what it says
       - role: assistant
+        content: I'll read the contents of world.txt for you.
         tool_calls:
           - id: toolcall_0
             type: function
@@ -44,4 +47,8 @@ conversations:
         tool_call_id: toolcall_1
         content: 1. World from the test!
       - role: assistant
-        content: 'The file contains: "World from the test!"'
+        content: |-
+          The file **world.txt** contains:
+          ```
+          World from the test!
+          ```