Commit 634bd9e
Address review feedback: explicit catch and corrected comment
- TestHelper.cs: replace bare `catch { }` in the backfill-drain `finally`
with `catch (Exception) { /* intentionally ignored: already propagated
via tcs */ }` to make the swallow intent explicit and satisfy CodeQL.
- sdkTestHelper.ts: update the comment above `getFutureFinalResponse` to
reflect that the live subscription is installed before the existing-
messages RPC fires, matching the actual call ordering.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent b4b23da commit 634bd9e
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments