Skip to content

Commit 6e369ac

Browse files
edburnsedburns
committed
Per github/copilot-sdk-internal#89 no per-language teams
1 parent 8d541ae commit 6e369ac

2 files changed

Lines changed: 16 additions & 17 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
* @github/copilot-sdk
2-
java/ @github/copilot-sdk-java

‎80-java-monorepo-add-01-remove-before-merge/dd-2989727-move-java-to-monorepo-plan.md‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,23 @@
66
2. [Permissions and Secrets Challenges](#2-permissions-and-secrets-challenges)
77
3. [Naming Convention Proposal](#3-naming-convention-proposal)
88
4. [Current Language Separation Assessment](#4-current-language-separation-assessment)5. [Workflow Inventory Tables](#5-workflow-inventory-tables)
9-
6. [Agents, Skills, Prompts, and Supporting Resources Inventory](#6-agents-skills-prompts-and-supporting-resources-inventory)
10-
7. [Pitfalls and Risk Register](#7-pitfalls-and-risk-register)
11-
8. [Post-Migration Verification Checklist](#8-post-migration-verification-checklist)
9+
5. [Agents, Skills, Prompts, and Supporting Resources Inventory](#6-agents-skills-prompts-and-supporting-resources-inventory)
10+
6. [Pitfalls and Risk Register](#7-pitfalls-and-risk-register)
11+
7. [Post-Migration Verification Checklist](#8-post-migration-verification-checklist)
1212

1313
- [Appendix A: Files to Copy vs. Merge vs. Delete](#appendix-a-files-to-copy-vs-merge-vs-delete)
1414
- [Appendix B: Unique Java Concerns vs Other Languages](#appendix-b-unique-java-concerns-vs-other-languages)
1515
- [Appendix C: Java Smoketest](#appendix-c-java-smoketest)
1616

17-
---
17+
---
1818

1919
## 1. Migration Plan — Phases
2020

2121
### Phase 0: Pre-Flight (Before Writing Any Code)
2222

2323
- [✅] **Provision secrets** in `github/copilot-sdk` (see §2A) See https://github.com/github/copilot-sdk-partners/issues/90
24-
- [⌛] **Verify CODEOWNERS team** access. See https://github.com/github/copilot-sdk-partners/issues/89
25-
- [⌛] **Check Maven Central Trusted Publisher** — can `github/copilot-sdk` publish to `com.github:copilot-sdk-java`? See
24+
- [✅] **Verify CODEOWNERS team** access. See https://github.com/github/copilot-sdk-partners/issues/89
25+
- [⌛] **Check Maven Central Trusted Publisher** — can `github/copilot-sdk` publish to `com.github:copilot-sdk-java`? See
2626
- [⌛] **Check GitHub Pages** — is it enabled? Can Java docs coexist? See https://github.com/github/copilot-sdk-partners/issues/85
2727
- [ ] **Confirm branch protection** — will new required status checks be accepted?
2828
- [ ] **Create tracking issue** in `github/copilot-sdk` for this migration
@@ -94,7 +94,7 @@
9494
- Add Maven ecosystem entry for `/java`
9595

9696
6. Update `CODEOWNERS`:
97-
- Add `java/ @github/copilot-sdk-java`
97+
- ~~Add `java/ @github/copilot-sdk-java`~~
9898

9999
### Phase 3: Publish Workflows
100100

@@ -195,14 +195,14 @@
195195

196196
The Java SDK publish workflow requires secrets that **do not currently exist** in the `copilot-sdk` repo:
197197

198-
| Old Secret | Old Used By | New Secret | New Used By | Notes |
199-
| ------------------------ | ------------------------------------------------ | -----------|-------------|---------------------------------------------------- |
200-
| `RELEASE_TOKEN` | `publish-maven.yml` | `JAVA_RELEASE_TOKEN` | `java-publish-maven.yml` | PAT with `contents:write` for pushing tags/commits during maven-release-plugin |
201-
| `GPG_SECRET_KEY` | `publish-maven.yml` | `JAVA_GPG_SECRET_KEY` | `java-publish-maven.yml` | GPG private key for signing Maven artifacts |
202-
| `GPG_PASSPHRASE` | `publish-maven.yml` | `JAVA_GPG_PASSPHRASE` | `java-publish-maven.yml` | Passphrase for the GPG key |
203-
| `MAVEN_CENTRAL_USERNAME` | `publish-maven.yml`, `publish-snapshot.yml` | `JAVA_MAVEN_CENTRAL_USERNAME` | `java-publish-maven.yml`, `java-publish-snapshot.yml` | Sonatype/Maven Central credentials |
198+
| Old Secret | Old Used By | New Secret | New Used By | Notes |
199+
| ------------------------ | ------------------------------------------------ | ----------------------------- | ----------------------------------------------------- | ------------------------------------------------------------------------------ |
200+
| `RELEASE_TOKEN` | `publish-maven.yml` | `JAVA_RELEASE_TOKEN` | `java-publish-maven.yml` | PAT with `contents:write` for pushing tags/commits during maven-release-plugin |
201+
| `GPG_SECRET_KEY` | `publish-maven.yml` | `JAVA_GPG_SECRET_KEY` | `java-publish-maven.yml` | GPG private key for signing Maven artifacts |
202+
| `GPG_PASSPHRASE` | `publish-maven.yml` | `JAVA_GPG_PASSPHRASE` | `java-publish-maven.yml` | Passphrase for the GPG key |
203+
| `MAVEN_CENTRAL_USERNAME` | `publish-maven.yml`, `publish-snapshot.yml` | `JAVA_MAVEN_CENTRAL_USERNAME` | `java-publish-maven.yml`, `java-publish-snapshot.yml` | Sonatype/Maven Central credentials |
204204
| `MAVEN_CENTRAL_PASSWORD` | `publish-maven.yml`, `publish-snapshot.yml` | `JAVA_MAVEN_CENTRAL_PASSWORD` | `java-publish-maven.yml`, `java-publish-snapshot.yml` | Sonatype/Maven Central credentials |
205-
| `COPILOT_GITHUB_TOKEN` | `build-test.yml`, `codegen-agentic-fix.lock.yml` | unchanged | | Token for Copilot CLI in CI |
205+
| `COPILOT_GITHUB_TOKEN` | `build-test.yml`, `codegen-agentic-fix.lock.yml` | unchanged | | Token for Copilot CLI in CI |
206206

207207
### 2B. Existing Secrets in copilot-sdk That May Conflict
208208

@@ -214,7 +214,7 @@ The Java SDK publish workflow requires secrets that **do not currently exist** i
214214
### 2C. Permissions / Access to Provision
215215

216216
- [✅] **Repository secrets**: File a ticket to add the 6 Java-specific secrets to `github/copilot-sdk`. See https://github.com/github/copilot-sdk-partners/issues/90
217-
- [⌛] **CODEOWNERS team**: Ensure `@github/copilot-sdk-java` team has access to `github/copilot-sdk` and is added to CODEOWNERS for `java/**`. See https://github.com/github/copilot-sdk-partners/issues/89 .
217+
- [✅] **CODEOWNERS team**: ~~Ensure `@github/copilot-sdk-java` team has access to `github/copilot-sdk` and is added to CODEOWNERS for `java/**`.~~ See https://github.com/github/copilot-sdk-partners/issues/89 .
218218
- [⌛] **Maven Central Trusted Publisher**: Currently configured for `github/copilot-sdk-java`. Must be updated to also allow publishing from `github/copilot-sdk` (or create a new namespace mapping). **This is the highest-risk permission issue** — Maven Central's Trusted Publisher setup ties the repository name to the publish flow. See https://github.com/github/copilot-sdk-partners/issues/91
219219
- [⌛] **GitHub Pages**: If `deploy-site.yml` moves, check if GitHub Pages is enabled on the monorepo and whether Java docs can coexist with any existing docs deployment. See https://github.com/github/copilot-sdk-partners/issues/85
220220
- [ ] **Branch protection**: Ensure `main` branch protection rules in copilot-sdk permit the Java CI workflows (merge queues, required status checks, etc.).
@@ -295,7 +295,7 @@ Keep existing names: `publish.yml`, `codegen-check.yml`, `scenario-builds.yml`,
295295
| **`sdk-consistency-review`** agentic workflow | Reviews PRs for cross-SDK parity (currently watches nodejs, python, go, dotnet) | Must add `java/` to the path triggers and update the agent prompt to include Java. |
296296
| **`copilot-setup-steps.yml`** | Sets up Node, Python, Go, .NET, Rust | Must add JDK 17 + Maven. |
297297
| **`copilot-instructions.md`** | Monorepo-wide instructions | Must incorporate Java-specific guidance. |
298-
| **`CODEOWNERS`** | Single `* @github/copilot-sdk` | Must add `java/ @github/copilot-sdk-java` line. |
298+
| **`CODEOWNERS`** | Single `* @github/copilot-sdk` | ~~Must add `java/ @github/copilot-sdk-java` line.~~ |
299299
| **`lsp.json`** | Configures C# and Go language servers for Copilot agent | May want to add Java LSP (jdtls or similar) — **optional**. |
300300

301301
### The Big Question: `reference-impl-sync`

0 commit comments

Comments
 (0)