Skip to content

Commit 70e5b66

Browse files
committed
review feedback
1 parent ae74e93 commit 70e5b66

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

go/internal/jsonrpc2/jsonrpc2.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,12 @@ func decodeMessage(data []byte) (any, error) {
454454
}, nil
455455
}
456456
if len(msg.ID) > 0 {
457+
if msg.Error != nil && len(msg.Result) > 0 {
458+
return nil, fmt.Errorf("response must not contain both result and error: %w", ErrInvalidRequest)
459+
}
460+
if msg.Error == nil && len(msg.Result) == 0 {
461+
return nil, fmt.Errorf("response must contain either result or error: %w", ErrInvalidRequest)
462+
}
457463
return &Response{
458464
JSONRPC: msg.JSONRPC,
459465
ID: msg.ID,

0 commit comments

Comments
 (0)