Simplify Go SDK

Author: SteveSandersonMS

go/client.go

@@ -29,12 +29,10 @@ package copilot
 
 import (
 	"bufio"
-	"bytes"
 	"context"
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io"
 	"net"
 	"os"
 	"os/exec"
@@ -49,11 +47,6 @@ import (
 	"github.com/github/copilot-sdk/go/rpc"
 )
 
-// readAll reads all data from r until EOF or error, returning the data read.
-func readAll(r io.Reader) ([]byte, error) {
-	return io.ReadAll(r)
-}
-
 // Client manages the connection to the Copilot CLI server and provides session management.
 //
 // The Client can either spawn a CLI server process or connect to an existing server.
@@ -92,7 +85,6 @@ type Client struct {
 	lifecycleHandlers      []SessionLifecycleHandler
 	typedLifecycleHandlers map[SessionLifecycleEventType][]SessionLifecycleHandler
 	lifecycleHandlersMux   sync.Mutex
-	stderrBuf              bytes.Buffer  // captures CLI stderr for error messages
 	processDone            chan struct{} // closed when CLI process exits
 	processError           error         // set before processDone is closed
 
@@ -1098,34 +1090,15 @@ func (c *Client) startCLIServer(ctx context.Context) error {
 			return fmt.Errorf("failed to create stdout pipe: %w", err)
 		}
 
-		stderr, err := c.process.StderrPipe()
-		if err != nil {
-			return fmt.Errorf("failed to create stderr pipe: %w", err)
-		}
-
 		if err := c.process.Start(); err != nil {
 			return fmt.Errorf("failed to start CLI server: %w", err)
 		}
 
-		// Read stderr in background - reads until EOF (process exit) then signals completion
-		stderrDone := make(chan struct{})
-		go func() {
-			// ReadAll reads until EOF, which happens when process terminates
-			data, _ := readAll(stderr)
-			c.stderrBuf.Write(data)
-			close(stderrDone)
-		}()
-
 		// Monitor process exit to signal pending requests
 		c.processDone = make(chan struct{})
 		go func() {
 			waitErr := c.process.Wait()
-			// Wait for stderr reader to finish before accessing buffer
-			<-stderrDone
-			stderrOutput := strings.TrimSpace(c.stderrBuf.String())
-			if stderrOutput != "" {
-				c.processError = fmt.Errorf("CLI process exited: %v\nstderr: %s", waitErr, stderrOutput)
-			} else if waitErr != nil {
+			if waitErr != nil {
 				c.processError = fmt.Errorf("CLI process exited: %v", waitErr)
 			} else {
 				c.processError = fmt.Errorf("CLI process exited unexpectedly")

go/internal/e2e/client_test.go

@@ -1,7 +1,6 @@
 package e2e
 
 import (
-	"strings"
 	"testing"
 	"time"
 
@@ -227,7 +226,7 @@ func TestClient(t *testing.T) {
 		client.Stop()
 	})
 
-	t.Run("should report error with stderr when CLI fails to start", func(t *testing.T) {
+	t.Run("should report error when CLI fails to start", func(t *testing.T) {
 		client := copilot.NewClient(&copilot.ClientOptions{
 			CLIPath:  cliPath,
 			CLIArgs:  []string{"--nonexistent-flag-for-testing"},
@@ -240,23 +239,13 @@ func TestClient(t *testing.T) {
 			t.Fatal("Expected Start to fail with invalid CLI args")
 		}
 
-		errStr := err.Error()
-		// Verify we get the stderr output in the error message
-		if !strings.Contains(errStr, "stderr") || !strings.Contains(errStr, "nonexistent") {
-			t.Errorf("Expected error to contain stderr output about invalid flag, got: %v", err)
-		}
-
-		// Verify subsequent calls also fail with the same error
+		// Verify subsequent calls also fail (don't hang)
 		session, err := client.CreateSession(t.Context(), nil)
 		if err == nil {
 			_, err = session.Send(t.Context(), copilot.MessageOptions{Prompt: "test"})
 		}
 		if err == nil {
 			t.Fatal("Expected CreateSession/Send to fail after CLI exit")
 		}
-		errStr = err.Error()
-		if !strings.Contains(errStr, "stderr") && !strings.Contains(errStr, "nonexistent") {
-			t.Errorf("Expected subsequent error to reference CLI failure, got: %v", err)
-		}
 	})
 }