Skip to content

Commit 83b65ff

Browse files
edburnsCopilot
andauthored
Apply review comments from standalone backport. (#1486)
* Address github/copilot-sdk-java#237 (comment) * Apply review comments from github/copilot-sdk-java#237 * fix: correct CopilotClientMode Javadoc links in java rpc configs Co-authored-by: edburns <75821+edburns@users.noreply.github.com> * fix: fully qualify CopilotClientMode Javadoc links Co-authored-by: edburns <75821+edburns@users.noreply.github.com> * Fix path for failsafe reports in workflow * Correct Javadoc formatting in ResumeSessionConfig Fix formatting of Javadoc comment for clarity. * Fix formatting in ResumeSessionConfig.java documentation * Fix formatting in SessionConfig.java documentation * Spotless --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent 60dac9d commit 83b65ff

6 files changed

Lines changed: 14 additions & 6 deletions

File tree

.githooks/pre-commit

100644100755
File mode changed.

.github/workflows/java-sdk-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,5 @@ jobs:
147147
path: |
148148
java/target/surefire-reports/
149149
java/target/surefire-reports-isolated/
150+
java/target/failsafe-reports/
150151
retention-days: 7

java/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Java SDK for programmatic control of GitHub Copilot CLI, enabling you to build A
3838

3939
```groovy
4040
implementation 'com.github:copilot-sdk-java:1.0.0-beta-10-java.0'
41-
41+
```
4242

4343
#### Snapshot Builds
4444

java/src/main/java/com/github/copilot/rpc/LargeToolOutputConfig.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
/*
2+
* Copyright (c) Microsoft Corporation. All rights reserved.
3+
* Licensed under the MIT License.
4+
*/
5+
16
package com.github.copilot.rpc;
27

38
import com.fasterxml.jackson.annotation.JsonInclude;

java/src/main/java/com/github/copilot/rpc/ResumeSessionConfig.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ public ResumeSessionConfig setProvider(ProviderConfig provider) {
258258
* {@code true}, telemetry is enabled for GitHub-authenticated sessions. When a
259259
* custom {@link ProviderConfig} (BYOK) is configured, session telemetry is
260260
* always disabled regardless of this setting. This is independent of
261-
* {@link com.github.copilot.rpc.CopilotClientOptions#getTelemetry()
261+
* {@link CopilotClientOptions#getTelemetry()
262262
* CopilotClientOptions.TelemetryConfig}, which configures OpenTelemetry export
263263
* for observability.
264264
*
@@ -1060,8 +1060,9 @@ public String getMcpOAuthTokenStorage() {
10601060
* <li>{@code "in-memory"} — tokens are stored in memory and discarded when the
10611061
* session ends</li>
10621062
* </ul>
1063-
* If not set, the SDK defaults to {@code "in-memory"} for safe multitenant
1064-
* behavior.
1063+
* If not set and the client is in {@link CopilotClientMode#EMPTY EMPTY} mode,
1064+
* the SDK defaults to {@code "in-memory"} for safe multitenant behavior. In
1065+
* other modes this field is left unset.
10651066
*
10661067
* @param mcpOAuthTokenStorage
10671068
* the storage mode

java/src/main/java/com/github/copilot/rpc/SessionConfig.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,8 +705,9 @@ public String getMcpOAuthTokenStorage() {
705705
* <li>{@code "in-memory"} — tokens are stored in memory and discarded when the
706706
* session ends</li>
707707
* </ul>
708-
* If not set, the SDK defaults to {@code "in-memory"} for safe multitenant
709-
* behavior.
708+
* If not set and the client is in {@link CopilotClientMode#EMPTY EMPTY} mode,
709+
* the SDK defaults to {@code "in-memory"} for safe multitenant behavior. In
710+
* other modes this field is left unset.
710711
*
711712
* @param mcpOAuthTokenStorage
712713
* the storage mode

0 commit comments

Comments
 (0)