Address 4 post-merge review comments on PR #1376

1. docs/getting-started.md: Python snippet still used the removed
   `CopilotClientOptions` wrapper. Switch to the flat-kwargs form
   (`CopilotClient(connection=RuntimeConnection.for_uri(...))`).

2. python/README.md custom-permission-handler example imported per-kind
   variants (`PermissionRequestShell`, `PermissionDecisionApproveOnce`,
   `PermissionDecisionReject`) from `copilot` — but only
   `PermissionRequest` and `PermissionRequestResult` are re-exported
   at the top level. Fix the example to import the variant classes from
   `copilot.generated.session_events`.

3. python/copilot/client.py `RuntimeConnection` docstring referenced
   the old factory names `stdio`/`tcp`/`uri`. Update to
   `for_stdio`/`for_tcp`/`for_uri` to match the renamed methods.

4. python/copilot/session.py comment above
   `PermissionRequestResult` told users to construct variants with
   `kind=...` arguments — but Phase L baked the discriminator into a
   `ClassVar` default, so the generated variants reject `kind=` at
   the call site. Update the comment to reflect the new ergonomics.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

docs/getting-started.md

@@ -1967,12 +1967,10 @@ const session = await client.createSession({ onPermissionRequest: approveAll });
 <summary><strong>Python</strong></summary>
 
 ```python
-from copilot import CopilotClient, CopilotClientOptions, RuntimeConnection
+from copilot import CopilotClient, RuntimeConnection
 from copilot.session import PermissionHandler
 
-client = CopilotClient(CopilotClientOptions(
-    connection=RuntimeConnection.for_uri("localhost:4321"),
-))
+client = CopilotClient(connection=RuntimeConnection.for_uri("localhost:4321"))
 await client.start()
 
 # Use the client normally

python/README.md

@@ -574,11 +574,10 @@ session = await client.create_session(
 Provide your own function to inspect each request and apply custom logic (sync or async):
 
 ```python
-from copilot import (
+from copilot import PermissionRequest, PermissionRequestResult
+from copilot.generated.session_events import (
     PermissionDecisionApproveOnce,
     PermissionDecisionReject,
-    PermissionRequest,
-    PermissionRequestResult,
     PermissionRequestShell,
 )
 

python/copilot/client.py

@@ -159,9 +159,10 @@ class TelemetryConfig(TypedDict, total=False):
 class RuntimeConnection:
     """Discriminated config describing how to reach the Copilot runtime.
 
-    Construct via the static factories :meth:`stdio`, :meth:`tcp`, or
-    :meth:`uri`. Each factory returns the matching subclass; pattern-match
-    on the subclass (or :func:`isinstance`) to branch on the transport.
+    Construct via the static factories :meth:`for_stdio`, :meth:`for_tcp`,
+    or :meth:`for_uri`. Each factory returns the matching subclass;
+    pattern-match on the subclass (or :func:`isinstance`) to branch on the
+    transport.
 
     Example:
         >>> CopilotClient()  # default: stdio with the bundled runtime

python/copilot/session.py

@@ -250,8 +250,9 @@ class PermissionNoResult:
 # The decision returned by a permission handler. Identical shape to the wire
 # ``PermissionDecision`` discriminated union, plus a :class:`PermissionNoResult`
 # sentinel for v1 servers. Construct via the generated variant classes:
-# ``PermissionDecisionApproveOnce(kind=...)``, ``PermissionDecisionReject(kind=...,
-# feedback=...)``, etc.
+# ``PermissionDecisionApproveOnce()``, ``PermissionDecisionReject(feedback=...)``,
+# etc. The ``kind`` discriminator is baked in as a ``ClassVar`` default by
+# codegen, so callers must not pass it.
 PermissionRequestResult = PermissionDecision | PermissionNoResult