Commit 884d730
Use Path.Join instead of Path.Combine to avoid silent-drop warnings
CodeQL flags Path.Combine because if a later argument is rooted, it
silently discards the earlier ones. Path.Join concatenates segments
literally and is the safer choice for these cases.
- E2ETestContext.ResolveSymlinks: use Path.Join when walking path
components (the loop appends user-controlled directory names that
realistically never start with a path separator on these temp dirs,
but the safer API removes the risk regardless).
- HooksE2ETests: use Path.Join for the protected-file lookup.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 21be3d1 commit 884d730
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
| 168 | + | |
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
0 commit comments