Skip to content

Commit 8fc2868

Browse files
committed
Merge remote-tracking branch 'origin/main' into stephentoub/port-csharp-validation
# Conflicts: # python/e2e/test_mcp_and_agents_e2e.py
2 parents 7d6e120 + 43d6aef commit 8fc2868

22 files changed

Lines changed: 151 additions & 173 deletions

dotnet/src/Generated/Rpc.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dotnet/src/Generated/SessionEvents.cs

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dotnet/test/E2E/EventFidelityE2ETests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ await session.SendAsync(new MessageOptions
147147
Prompt = "What is 9+9? Reply with just the number.",
148148
});
149149

150-
var pendingEvent = await pendingMessagesModified;
151150
var answer = await TestHelper.GetFinalAssistantMessageAsync(session);
151+
var pendingEvent = await pendingMessagesModified;
152152

153153
Assert.NotNull(pendingEvent);
154154
Assert.Contains("18", answer?.Data.Content ?? string.Empty);

dotnet/test/E2E/SessionMcpAndAgentConfigE2ETests.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -401,14 +401,6 @@ public async Task Should_Accept_Both_MCP_Servers_And_Custom_Agents()
401401
});
402402

403403
Assert.Matches(@"^[a-f0-9-]+$", session.SessionId);
404-
405-
await session.SendAsync(new MessageOptions { Prompt = "What is 7+7?" });
406-
407-
// Use a longer timeout to tolerate slower MCP server spawning on Windows.
408-
var message = await TestHelper.GetFinalAssistantMessageAsync(session, TimeSpan.FromSeconds(120));
409-
Assert.NotNull(message);
410-
Assert.Contains("14", message!.Data.Content);
411-
412404
await session.DisposeAsync();
413405
}
414406

go/internal/e2e/mcp_and_agents_e2e_test.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -403,22 +403,6 @@ func TestCombinedConfigurationE2E(t *testing.T) {
403403
t.Error("Expected non-empty session ID")
404404
}
405405

406-
_, err = session.Send(t.Context(), copilot.MessageOptions{
407-
Prompt: "What is 7+7?",
408-
})
409-
if err != nil {
410-
t.Fatalf("Failed to send message: %v", err)
411-
}
412-
413-
message, err := testharness.GetFinalAssistantMessage(t.Context(), session)
414-
if err != nil {
415-
t.Fatalf("Failed to get final message: %v", err)
416-
}
417-
418-
if md, ok := message.Data.(*copilot.AssistantMessageData); !ok || !strings.Contains(md.Content, "14") {
419-
t.Errorf("Expected message to contain '14', got: %v", message.Data)
420-
}
421-
422406
session.Disconnect()
423407
})
424408
}

go/internal/e2e/rpc_session_state_e2e_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ func TestRpcSessionStateE2E(t *testing.T) {
473473
t.Errorf("Expected non-zero sessionStartTime, got %s", metrics.SessionStartTime)
474474
}
475475
if metrics.TotalNanoAiu != nil && *metrics.TotalNanoAiu < 0 {
476-
t.Errorf("Expected non-negative totalNanoAiu, got %d", *metrics.TotalNanoAiu)
476+
t.Errorf("Expected non-negative totalNanoAiu, got %f", *metrics.TotalNanoAiu)
477477
}
478478
for k, detail := range metrics.TokenDetails {
479479
if detail.TokenCount < 0 {
@@ -482,7 +482,7 @@ func TestRpcSessionStateE2E(t *testing.T) {
482482
}
483483
for modelName, modelMetric := range metrics.ModelMetrics {
484484
if modelMetric.TotalNanoAiu != nil && *modelMetric.TotalNanoAiu < 0 {
485-
t.Errorf("Expected non-negative totalNanoAiu for model %q, got %d", modelName, *modelMetric.TotalNanoAiu)
485+
t.Errorf("Expected non-negative totalNanoAiu for model %q, got %f", modelName, *modelMetric.TotalNanoAiu)
486486
}
487487
for tokenType, detail := range modelMetric.TokenDetails {
488488
if detail.TokenCount < 0 {

go/rpc/zrpc.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/rpc/zsession_events.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/package-lock.json

Lines changed: 48 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"author": "GitHub",
5757
"license": "MIT",
5858
"dependencies": {
59-
"@github/copilot": "^1.0.51-1",
59+
"@github/copilot": "^1.0.51-2",
6060
"vscode-jsonrpc": "^8.2.1",
6161
"zod": "^4.3.6"
6262
},

0 commit comments

Comments
 (0)