Skip to content

Commit 985543a

Browse files
skip postToolUse hook tests broken by runtime (issue #972)
1 parent a938ece commit 985543a

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

dotnet/test/HooksTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ await session.SendAsync(new MessageOptions
4646
Assert.Contains(preToolUseInputs, i => !string.IsNullOrEmpty(i.ToolName));
4747
}
4848

49-
[Fact]
49+
// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
50+
[Fact(Skip = "Runtime postToolUse hooks broken")]
5051
public async Task Should_Invoke_PostToolUse_Hook_After_Model_Runs_A_Tool()
5152
{
5253
var postToolUseInputs = new List<PostToolUseHookInput>();
@@ -83,7 +84,8 @@ await session.SendAsync(new MessageOptions
8384
Assert.Contains(postToolUseInputs, i => i.ToolResult != null);
8485
}
8586

86-
[Fact]
87+
// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
88+
[Fact(Skip = "Runtime postToolUse hooks broken")]
8789
public async Task Should_Invoke_Both_PreToolUse_And_PostToolUse_Hooks_For_Single_Tool_Call()
8890
{
8991
var preToolUseInputs = new List<PreToolUseHookInput>();

go/internal/e2e/hooks_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ func TestHooks(t *testing.T) {
7474
}
7575
})
7676

77+
// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
7778
t.Run("should invoke postToolUse hook after model runs a tool", func(t *testing.T) {
79+
t.Skip("Runtime postToolUse hooks broken")
7880
ctx.ConfigureForTest(t)
7981

8082
var postToolUseInputs []copilot.PostToolUseHookInput
@@ -139,7 +141,9 @@ func TestHooks(t *testing.T) {
139141
}
140142
})
141143

144+
// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
142145
t.Run("should invoke both preToolUse and postToolUse hooks for a single tool call", func(t *testing.T) {
146+
t.Skip("Runtime postToolUse hooks broken")
143147
ctx.ConfigureForTest(t)
144148

145149
var preToolUseInputs []copilot.PreToolUseHookInput

nodejs/test/e2e/hooks.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ describe("Session hooks", async () => {
4848
await session.disconnect();
4949
});
5050

51-
it("should invoke postToolUse hook after model runs a tool", async () => {
51+
// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
52+
it.skip("should invoke postToolUse hook after model runs a tool", async () => {
5253
const postToolUseInputs: PostToolUseHookInput[] = [];
5354

5455
const session = await client.createSession({
@@ -79,7 +80,8 @@ describe("Session hooks", async () => {
7980
await session.disconnect();
8081
});
8182

82-
it("should invoke both preToolUse and postToolUse hooks for a single tool call", async () => {
83+
// TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
84+
it.skip("should invoke both preToolUse and postToolUse hooks for a single tool call", async () => {
8385
const preToolUseInputs: PreToolUseHookInput[] = [];
8486
const postToolUseInputs: PostToolUseHookInput[] = [];
8587

python/e2e/test_hooks.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ async def on_pre_tool_use(input_data, invocation):
4141

4242
await session.disconnect()
4343

44+
# TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
45+
@pytest.mark.skip(reason="Runtime postToolUse hooks broken")
4446
async def test_should_invoke_posttooluse_hook_after_model_runs_a_tool(
4547
self, ctx: E2ETestContext
4648
):
@@ -71,6 +73,8 @@ async def on_post_tool_use(input_data, invocation):
7173

7274
await session.disconnect()
7375

76+
# TODO: Re-enable once runtime postToolUse hooks are fixed (https://github.com/github/copilot-sdk/issues/972)
77+
@pytest.mark.skip(reason="Runtime postToolUse hooks broken")
7478
async def test_should_invoke_both_pretooluse_and_posttooluse_hooks_for_a_single_tool_call(
7579
self, ctx: E2ETestContext
7680
):

0 commit comments

Comments
 (0)