Formatting

Author: SteveSandersonMS

go/internal/e2e/permissions_test.go

@@ -161,7 +161,7 @@ func TestPermissions(t *testing.T) {
 		ctx.ConfigureForTest(t)
 
 		session, err := client.CreateSession(t.Context(), &copilot.SessionConfig{
-			OnPermissionRequest: func(request copilot.PermissionRequest, invocation copilot.ToolInvocation) (copilot.PermissionRequestResult, error) {
+			OnPermissionRequest: func(request copilot.PermissionRequest, invocation copilot.PermissionInvocation) (copilot.PermissionRequestResult, error) {
 				return copilot.PermissionRequestResult{Kind: "denied-no-approval-rule-and-could-not-request-from-user"}, nil
 			},
 		})
@@ -211,7 +211,7 @@ func TestPermissions(t *testing.T) {
 		}
 
 		session2, err := client.ResumeSession(t.Context(), sessionID, &copilot.ResumeSessionConfig{
-			OnPermissionRequest: func(request copilot.PermissionRequest, invocation copilot.ToolInvocation) (copilot.PermissionRequestResult, error) {
+			OnPermissionRequest: func(request copilot.PermissionRequest, invocation copilot.PermissionInvocation) (copilot.PermissionRequestResult, error) {
 				return copilot.PermissionRequestResult{Kind: "denied-no-approval-rule-and-could-not-request-from-user"}, nil
 			},
 		})

nodejs/test/client.test.ts

@@ -10,7 +10,9 @@ describe("CopilotClient", () => {
         await client.start();
         onTestFinished(() => client.forceStop());
 
-        await expect((client as any).createSession({})).rejects.toThrow(/onPermissionRequest.*is required/);
+        await expect((client as any).createSession({})).rejects.toThrow(
+            /onPermissionRequest.*is required/
+        );
     });
 
     it("throws when resumeSession is called without onPermissionRequest", async () => {
@@ -19,9 +21,9 @@ describe("CopilotClient", () => {
         onTestFinished(() => client.forceStop());
 
         const session = await client.createSession({ onPermissionRequest: approveAll });
-        await expect(
-            (client as any).resumeSession(session.sessionId, {})
-        ).rejects.toThrow(/onPermissionRequest.*is required/);
+        await expect((client as any).resumeSession(session.sessionId, {})).rejects.toThrow(
+            /onPermissionRequest.*is required/
+        );
     });
 
     it("returns a standardized failure result when a tool is not registered", async () => {
@@ -67,7 +69,10 @@ describe("CopilotClient", () => {
 
         const session = await client.createSession({ onPermissionRequest: approveAll });
         const spy = vi.spyOn((client as any).connection!, "sendRequest");
-        await client.resumeSession(session.sessionId, { clientName: "my-app", onPermissionRequest: approveAll });
+        await client.resumeSession(session.sessionId, {
+            clientName: "my-app",
+            onPermissionRequest: approveAll,
+        });
 
         expect(spy).toHaveBeenCalledWith(
             "session.resume",

python/copilot/client.py

@@ -434,7 +434,8 @@ async def create_session(self, config: SessionConfig) -> CopilotSession:
 
         Example:
             >>> # Basic session
-            >>> session = await client.create_session({"on_permission_request": PermissionHandler.approve_all})
+            >>> config = {"on_permission_request": PermissionHandler.approve_all}
+            >>> session = await client.create_session(config)
             >>>
             >>> # Session with model and streaming
             >>> session = await client.create_session({
@@ -606,7 +607,8 @@ async def resume_session(self, session_id: str, config: ResumeSessionConfig) ->
 
         Example:
             >>> # Resume a previous session
-            >>> session = await client.resume_session("session-123", {"on_permission_request": PermissionHandler.approve_all})
+            >>> config = {"on_permission_request": PermissionHandler.approve_all}
+            >>> session = await client.resume_session("session-123", config)
             >>>
             >>> # Resume with new tools
             >>> session = await client.resume_session("session-123", {

python/e2e/test_permissions.py

@@ -76,9 +76,7 @@ async def test_should_deny_tool_operations_when_handler_explicitly_denies(
         def deny_all(request, invocation):
             return {"kind": "denied-no-approval-rule-and-could-not-request-from-user"}
 
-        session = await ctx.client.create_session(
-            {"on_permission_request": deny_all}
-        )
+        session = await ctx.client.create_session({"on_permission_request": deny_all})
 
         denied_events = []
         done_event = asyncio.Event()
@@ -89,9 +87,7 @@ def on_event(event):
                 msg = (
                     error
                     if isinstance(error, str)
-                    else (
-                        getattr(error, "message", None) if error is not None else None
-                    )
+                    else (getattr(error, "message", None) if error is not None else None)
                 )
                 if msg and "Permission denied" in msg:
                     denied_events.append(event)
@@ -120,9 +116,7 @@ async def test_should_deny_tool_operations_when_handler_explicitly_denies_after_
         def deny_all(request, invocation):
             return {"kind": "denied-no-approval-rule-and-could-not-request-from-user"}
 
-        session2 = await ctx.client.resume_session(
-            session_id, {"on_permission_request": deny_all}
-        )
+        session2 = await ctx.client.resume_session(session_id, {"on_permission_request": deny_all})
 
         denied_events = []
         done_event = asyncio.Event()
@@ -133,9 +127,7 @@ def on_event(event):
                 msg = (
                     error
                     if isinstance(error, str)
-                    else (
-                        getattr(error, "message", None) if error is not None else None
-                    )
+                    else (getattr(error, "message", None) if error is not None else None)
                 )
                 if msg and "Permission denied" in msg:
                     denied_events.append(event)
@@ -151,9 +143,7 @@ def on_event(event):
 
         await session2.destroy()
 
-    async def test_should_work_with_approve_all_permission_handler(
-        self, ctx: E2ETestContext
-    ):
+    async def test_should_work_with_approve_all_permission_handler(self, ctx: E2ETestContext):
         """Test that sessions work with approve-all permission handler"""
         session = await ctx.client.create_session(
             {"on_permission_request": PermissionHandler.approve_all}