Skip to content

Commit 9ab8617

Browse files
chore: address sanity-check findings
- Revert unintended java/mvnw mode change (644 -> 755) introduced in the Java SDK commit; CI runs mvnw with explicit bash and doesn't require the exec bit. - Refresh Rust doc comments left stale after renaming request_mcp_apps -> enable_mcp_apps on the user-facing API (session.rs warn helper docstring + tracing message; UiCapabilities.mcp_apps cref). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 8541da5 commit 9ab8617

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

java/mvnw

100755100644
File mode changed.

rust/src/session.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1125,7 +1125,7 @@ impl Client {
11251125

11261126
type CommandHandlerMap = HashMap<String, Arc<dyn CommandHandler>>;
11271127

1128-
/// Emit a `tracing::warn!` when the consumer set `request_mcp_apps: Some(true)`
1128+
/// Emit a `tracing::warn!` when the consumer set `enable_mcp_apps: true`
11291129
/// on create/resume but the runtime did not advertise `capabilities.ui.mcp_apps`
11301130
/// in the response. The runtime silently drops the opt-in when its `MCP_APPS`
11311131
/// feature flag (or `COPILOT_MCP_APPS=true` env override) is unset, so without
@@ -1149,7 +1149,7 @@ fn warn_if_mcp_apps_dropped(
11491149
}
11501150
tracing::warn!(
11511151
session_id = %session_id,
1152-
"request_mcp_apps was set but the runtime did not advertise capabilities.ui.mcpApps; the MCP_APPS feature flag or COPILOT_MCP_APPS=true environment override is likely unset and the MCP Apps surface is unavailable for this session"
1152+
"enable_mcp_apps was set but the runtime did not advertise capabilities.ui.mcpApps; the MCP_APPS feature flag or COPILOT_MCP_APPS=true environment override is likely unset and the MCP Apps surface is unavailable for this session"
11531153
);
11541154
}
11551155

rust/src/types.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3293,9 +3293,9 @@ pub struct UiCapabilities {
32933293
pub elicitation: Option<bool>,
32943294
/// Whether the runtime has accepted the session's MCP Apps (SEP-1865)
32953295
/// opt-in. `Some(true)` when the consumer set
3296-
/// [`SessionConfig::request_mcp_apps`] / [`ResumeSessionConfig::request_mcp_apps`]
3297-
/// to `Some(true)` on create/resume **and** the runtime's `MCP_APPS`
3298-
/// feature flag (or `COPILOT_MCP_APPS=true` env override) is on. Otherwise
3296+
/// [`SessionConfig::enable_mcp_apps`] / [`ResumeSessionConfig::enable_mcp_apps`]
3297+
/// to `true` on create/resume **and** the runtime's `MCP_APPS` feature
3298+
/// flag (or `COPILOT_MCP_APPS=true` env override) is on. Otherwise
32993299
/// absent or `Some(false)`, indicating the runtime silently dropped the
33003300
/// opt-in.
33013301
#[serde(skip_serializing_if = "Option::is_none")]

0 commit comments

Comments
 (0)