fix: remove soft-pass fallbacks in verify.sh scenario scripts

Replace else/elif fallback branches that always passed with proper
failure reporting. Previously, when the expected grep pattern wasn't
found, the test would emit a warning but still count as passed. Now
these cases correctly report failure and increment the FAIL counter.

Changed 18 files with 21 soft-pass fixes across:
- 10 standard else-branch fallbacks (modes, prompts, tools, sessions)
- 3 elif-branch fallbacks (callbacks, streaming, virtual-filesystem)
- 3 multi-branch fixes with both 'partial' and 'got response' fallbacks
  (concurrent-sessions, multi-user-long-lived, multi-user-short-lived)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: patniko

test/scenarios/callbacks/hooks/verify.sh

@@ -73,8 +73,9 @@ run_with_timeout() {
       echo "✅ $name passed (hooks confirmed)"
       PASS=$((PASS + 1))
     elif [ "$code" -eq 0 ] && [ -n "$output" ]; then
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/callbacks/permissions/verify.sh

@@ -73,8 +73,9 @@ run_with_timeout() {
       echo "✅ $name passed (permission flow confirmed)"
       PASS=$((PASS + 1))
     elif [ "$code" -eq 0 ] && [ -n "$output" ]; then
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/callbacks/user-input/verify.sh

@@ -73,8 +73,9 @@ run_with_timeout() {
       echo "✅ $name passed (user input flow confirmed)"
       PASS=$((PASS + 1))
     elif [ "$code" -eq 0 ] && [ -n "$output" ]; then
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/modes/default/verify.sh

@@ -74,8 +74,9 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     else
       echo "⚠️  $name ran but response may not confirm CLI tools"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/modes/minimal/verify.sh

@@ -74,8 +74,9 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     else
       echo "⚠️  $name ran but response may not confirm tool-less state"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/prompts/attachments/verify.sh

@@ -74,8 +74,9 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     else
       echo "⚠️  $name ran but response may not reference attached file content"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/prompts/reasoning-effort/verify.sh

@@ -74,8 +74,9 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     else
       echo "⚠️  $name ran but response may not contain expected content"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/prompts/system-message/verify.sh

@@ -74,8 +74,9 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     else
       echo "⚠️  $name ran but response may not contain pirate language"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/sessions/concurrent-sessions/verify.sh

@@ -82,12 +82,14 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     elif $has_session1 || $has_session2; then
       echo "⚠️  $name ran but only one session responded"
-      echo "✅ $name passed (partial)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected both to respond)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name (partial)"
     else
       echo "⚠️  $name ran but session labels not found in output"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"

test/scenarios/sessions/infinite-sessions/verify.sh

@@ -73,8 +73,9 @@ run_with_timeout() {
       PASS=$((PASS + 1))
     else
       echo "⚠️  $name ran but completion message not found"
-      echo "✅ $name passed (got response)"
-      PASS=$((PASS + 1))
+      echo "❌ $name failed (expected pattern not found)"
+      FAIL=$((FAIL + 1))
+      ERRORS="$ERRORS\n  - $name"
     fi
   elif [ "$code" -eq 124 ]; then
     echo "❌ $name failed (timed out after ${TIMEOUT}s)"