Address PR review feedback

- Remove unused 'answer' variable in Python streaming fidelity test
- Add onTestFinished cleanup for newClient in Node.js streaming resume test
- Remove streaming tests from Node.js session.test.ts (were still referencing deleted session/ snapshots)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

nodejs/test/e2e/session.test.ts

@@ -296,56 +296,6 @@ describe("Sessions", async () => {
         expect(answer?.data.content).toContain("4");
     });
 
-    it("should receive streaming delta events when streaming is enabled", async () => {
-        const session = await client.createSession({
-            onPermissionRequest: approveAll,
-            streaming: true,
-        });
-
-        const deltaContents: string[] = [];
-        let _finalMessage: string | undefined;
-
-        // Set up event listener before sending
-        const unsubscribe = session.on((event) => {
-            if (event.type === "assistant.message_delta") {
-                const delta = (event.data as { deltaContent?: string }).deltaContent;
-                if (delta) {
-                    deltaContents.push(delta);
-                }
-            } else if (event.type === "assistant.message") {
-                _finalMessage = event.data.content;
-            }
-        });
-
-        const assistantMessage = await session.sendAndWait({ prompt: "What is 2+2?" });
-
-        unsubscribe();
-
-        // Should have received delta events
-        expect(deltaContents.length).toBeGreaterThan(0);
-
-        // Accumulated deltas should equal the final message
-        const accumulated = deltaContents.join("");
-        expect(accumulated).toBe(assistantMessage?.data.content);
-
-        // Final message should contain the answer
-        expect(assistantMessage?.data.content).toContain("4");
-    });
-
-    it("should pass streaming option to session creation", async () => {
-        // Verify that the streaming option is accepted without errors
-        const session = await client.createSession({
-            onPermissionRequest: approveAll,
-            streaming: true,
-        });
-
-        expect(session.sessionId).toMatch(/^[a-f0-9-]+$/);
-
-        // Session should still work normally
-        const assistantMessage = await session.sendAndWait({ prompt: "What is 1+1?" });
-        expect(assistantMessage?.data.content).toContain("2");
-    });
-
     it("should receive session events", async () => {
         const session = await client.createSession({ onPermissionRequest: approveAll });
         const receivedEvents: Array<{ type: string }> = [];

nodejs/test/e2e/streaming_fidelity.test.ts

@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *--------------------------------------------------------------------------------------------*/
 
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, onTestFinished } from "vitest";
 import { CopilotClient, SessionEvent, approveAll } from "../../src/index.js";
 import { createSdkTestContext, isCI } from "./harness/sdkTestContext";
 
@@ -85,6 +85,7 @@ describe("Streaming Fidelity", async () => {
             env,
             githubToken: isCI ? "fake-token-for-e2e-tests" : undefined,
         });
+        onTestFinished(() => newClient.forceStop());
         const session2 = await newClient.resumeSession(session.sessionId, {
             onPermissionRequest: approveAll,
             streaming: true,

python/e2e/test_streaming_fidelity.py

@@ -12,19 +12,15 @@
 
 
 class TestStreamingFidelity:
-    async def test_should_produce_delta_events_when_streaming_is_enabled(
-        self, ctx: E2ETestContext
-    ):
+    async def test_should_produce_delta_events_when_streaming_is_enabled(self, ctx: E2ETestContext):
         session = await ctx.client.create_session(
             {"streaming": True, "on_permission_request": PermissionHandler.approve_all}
         )
 
         events = []
         session.on(lambda event: events.append(event))
 
-        answer = await session.send_and_wait(
-            {"prompt": "Count from 1 to 5, separated by commas."}
-        )
+        await session.send_and_wait({"prompt": "Count from 1 to 5, separated by commas."})
 
         types = [e.type.value for e in events]
 
@@ -48,9 +44,7 @@ async def test_should_produce_delta_events_when_streaming_is_enabled(
 
         await session.destroy()
 
-    async def test_should_not_produce_deltas_when_streaming_is_disabled(
-        self, ctx: E2ETestContext
-    ):
+    async def test_should_not_produce_deltas_when_streaming_is_disabled(self, ctx: E2ETestContext):
         session = await ctx.client.create_session(
             {"streaming": False, "on_permission_request": PermissionHandler.approve_all}
         )