Address Rust hook CodeQL comments

Move unsupported hook error checking through a shared E2E helper so the error bindings are used outside assertion macro expansion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: stephentoub

rust/tests/e2e/hooks.rs

@@ -6,9 +6,7 @@ use github_copilot_sdk::hooks::{
     SessionHooks,
 };
 
-use super::support::with_e2e_context;
-
-const UNSUPPORTED_SDK_HOOKS_MESSAGE: &str = "SDK hook callbacks are no longer supported";
+use super::support::{assert_unsupported_hooks_error, with_e2e_context};
 
 #[tokio::test]
 async fn rejects_sdk_callback_hooks() {
@@ -37,10 +35,7 @@ async fn assert_unsupported_hooks(
             session.disconnect().await.expect("disconnect session");
             panic!("expected SDK callback hooks to be rejected");
         }
-        Err(err) => assert!(
-            err.to_string().contains(UNSUPPORTED_SDK_HOOKS_MESSAGE),
-            "expected unsupported hooks error, got: {err}"
-        ),
+        Err(err) => assert_unsupported_hooks_error(err),
     }
 }
 

rust/tests/e2e/hooks_extended.rs

@@ -8,9 +8,7 @@ use github_copilot_sdk::hooks::{
     SessionStartOutput, UserPromptSubmittedInput, UserPromptSubmittedOutput,
 };
 
-use super::support::with_e2e_context;
-
-const UNSUPPORTED_SDK_HOOKS_MESSAGE: &str = "SDK hook callbacks are no longer supported";
+use super::support::{assert_unsupported_hooks_error, with_e2e_context};
 
 #[tokio::test]
 async fn rejects_extended_sdk_callback_hooks() {
@@ -32,10 +30,7 @@ async fn rejects_extended_sdk_callback_hooks() {
                         session.disconnect().await.expect("disconnect session");
                         panic!("expected SDK callback hooks to be rejected");
                     }
-                    Err(err) => assert!(
-                        err.to_string().contains(UNSUPPORTED_SDK_HOOKS_MESSAGE),
-                        "expected unsupported hooks error, got: {err}"
-                    ),
+                    Err(err) => assert_unsupported_hooks_error(err),
                 }
                 client.stop().await.expect("stop client");
             })

rust/tests/e2e/pre_mcp_tool_call_hook.rs

@@ -6,9 +6,7 @@ use github_copilot_sdk::hooks::{
 };
 use serde_json::json;
 
-use super::support::with_e2e_context;
-
-const UNSUPPORTED_SDK_HOOKS_MESSAGE: &str = "SDK hook callbacks are no longer supported";
+use super::support::{assert_unsupported_hooks_error, with_e2e_context};
 
 #[tokio::test]
 async fn rejects_sdk_premcptoolcall_callback_hooks() {
@@ -30,10 +28,7 @@ async fn rejects_sdk_premcptoolcall_callback_hooks() {
                         session.disconnect().await.expect("disconnect session");
                         panic!("expected SDK callback hooks to be rejected");
                     }
-                    Err(err) => assert!(
-                        err.to_string().contains(UNSUPPORTED_SDK_HOOKS_MESSAGE),
-                        "expected unsupported hooks error, got: {err}"
-                    ),
+                    Err(err) => assert_unsupported_hooks_error(err),
                 }
                 client.stop().await.expect("stop client");
             })

rust/tests/e2e/subagent_hooks.rs

@@ -6,9 +6,7 @@ use github_copilot_sdk::hooks::{
     SessionHooks,
 };
 
-use super::support::with_e2e_context;
-
-const UNSUPPORTED_SDK_HOOKS_MESSAGE: &str = "SDK hook callbacks are no longer supported";
+use super::support::{assert_unsupported_hooks_error, with_e2e_context};
 
 #[tokio::test]
 async fn rejects_sdk_callback_hooks_for_sub_agent_hook_propagation() {
@@ -30,10 +28,7 @@ async fn rejects_sdk_callback_hooks_for_sub_agent_hook_propagation() {
                         session.disconnect().await.expect("disconnect session");
                         panic!("expected SDK callback hooks to be rejected");
                     }
-                    Err(err) => assert!(
-                        err.to_string().contains(UNSUPPORTED_SDK_HOOKS_MESSAGE),
-                        "expected unsupported hooks error, got: {err}"
-                    ),
+                    Err(err) => assert_unsupported_hooks_error(err),
                 }
                 client.stop().await.expect("stop client");
             })

rust/tests/e2e/support.rs

@@ -21,9 +21,19 @@ use tokio::sync::Semaphore;
 static E2E_CONCURRENCY: LazyLock<Semaphore> = LazyLock::new(|| Semaphore::new(e2e_concurrency()));
 
 pub const DEFAULT_TEST_TOKEN: &str = "rust-e2e-token";
+const UNSUPPORTED_SDK_HOOKS_MESSAGE: &str = "SDK hook callbacks are no longer supported";
 
 type TestFuture<'a> = Pin<Box<dyn Future<Output = ()> + 'a>>;
 
+pub fn assert_unsupported_hooks_error(err: impl std::fmt::Display) {
+    let message = err.to_string();
+    if message.contains(UNSUPPORTED_SDK_HOOKS_MESSAGE) {
+        return;
+    }
+
+    panic!("expected unsupported hooks error, got: {message}");
+}
+
 pub async fn with_e2e_context<F>(category: &str, snapshot_name: &str, test: F)
 where
     F: for<'a> FnOnce(&'a mut E2eContext) -> TestFuture<'a>,