Skip to content

Commit b4a8661

Browse files
fix: remove mcp/pr/ado from goInitialisms to avoid SessionRpc.MCP rename
resolveType() already handles type name reconciliation from quicktype output, so these initialisms aren't needed and would cause an unnecessary breaking change to the SessionRpc.Mcp field name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 08ef0c4 commit b4a8661

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

go/generated_session_events.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/rpc/generated_rpc.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -972,12 +972,12 @@ func (a *SkillsRpcApi) Reload(ctx context.Context) (*SessionSkillsReloadResult,
972972
return &result, nil
973973
}
974974

975-
type MCPRpcApi struct {
975+
type McpRpcApi struct {
976976
client *jsonrpc2.Client
977977
sessionID string
978978
}
979979

980-
func (a *MCPRpcApi) List(ctx context.Context) (*SessionMCPListResult, error) {
980+
func (a *McpRpcApi) List(ctx context.Context) (*SessionMCPListResult, error) {
981981
req := map[string]interface{}{"sessionId": a.sessionID}
982982
raw, err := a.client.Request("session.mcp.list", req)
983983
if err != nil {
@@ -990,7 +990,7 @@ func (a *MCPRpcApi) List(ctx context.Context) (*SessionMCPListResult, error) {
990990
return &result, nil
991991
}
992992

993-
func (a *MCPRpcApi) Enable(ctx context.Context, params *SessionMCPEnableParams) (*SessionMCPEnableResult, error) {
993+
func (a *McpRpcApi) Enable(ctx context.Context, params *SessionMCPEnableParams) (*SessionMCPEnableResult, error) {
994994
req := map[string]interface{}{"sessionId": a.sessionID}
995995
if params != nil {
996996
req["serverName"] = params.ServerName
@@ -1006,7 +1006,7 @@ func (a *MCPRpcApi) Enable(ctx context.Context, params *SessionMCPEnableParams)
10061006
return &result, nil
10071007
}
10081008

1009-
func (a *MCPRpcApi) Disable(ctx context.Context, params *SessionMCPDisableParams) (*SessionMCPDisableResult, error) {
1009+
func (a *McpRpcApi) Disable(ctx context.Context, params *SessionMCPDisableParams) (*SessionMCPDisableResult, error) {
10101010
req := map[string]interface{}{"sessionId": a.sessionID}
10111011
if params != nil {
10121012
req["serverName"] = params.ServerName
@@ -1022,7 +1022,7 @@ func (a *MCPRpcApi) Disable(ctx context.Context, params *SessionMCPDisableParams
10221022
return &result, nil
10231023
}
10241024

1025-
func (a *MCPRpcApi) Reload(ctx context.Context) (*SessionMCPReloadResult, error) {
1025+
func (a *McpRpcApi) Reload(ctx context.Context) (*SessionMCPReloadResult, error) {
10261026
req := map[string]interface{}{"sessionId": a.sessionID}
10271027
raw, err := a.client.Request("session.mcp.reload", req)
10281028
if err != nil {
@@ -1240,7 +1240,7 @@ type SessionRpc struct {
12401240
Fleet *FleetRpcApi
12411241
Agent *AgentRpcApi
12421242
Skills *SkillsRpcApi
1243-
MCP *MCPRpcApi
1243+
Mcp *McpRpcApi
12441244
Plugins *PluginsRpcApi
12451245
Extensions *ExtensionsRpcApi
12461246
Compaction *CompactionRpcApi
@@ -1283,7 +1283,7 @@ func NewSessionRpc(client *jsonrpc2.Client, sessionID string) *SessionRpc {
12831283
Fleet: &FleetRpcApi{client: client, sessionID: sessionID},
12841284
Agent: &AgentRpcApi{client: client, sessionID: sessionID},
12851285
Skills: &SkillsRpcApi{client: client, sessionID: sessionID},
1286-
MCP: &MCPRpcApi{client: client, sessionID: sessionID},
1286+
Mcp: &McpRpcApi{client: client, sessionID: sessionID},
12871287
Plugins: &PluginsRpcApi{client: client, sessionID: sessionID},
12881288
Extensions: &ExtensionsRpcApi{client: client, sessionID: sessionID},
12891289
Compaction: &CompactionRpcApi{client: client, sessionID: sessionID},

scripts/codegen/go.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const execFileAsync = promisify(execFile);
2626
// ── Utilities ───────────────────────────────────────────────────────────────
2727

2828
// Go initialisms that should be all-caps
29-
const goInitialisms = new Set(["id", "url", "api", "http", "https", "json", "xml", "html", "css", "sql", "ssh", "tcp", "udp", "ip", "rpc", "mcp", "pr", "ado"]);
29+
const goInitialisms = new Set(["id", "url", "api", "http", "https", "json", "xml", "html", "css", "sql", "ssh", "tcp", "udp", "ip", "rpc"]);
3030

3131
function toPascalCase(s: string): string {
3232
return s

0 commit comments

Comments
 (0)