Skip to content

Commit b8ef5b0

Browse files
stephentoubCopilot
andcommitted
Fix consistency gaps: update JSDoc and drop stale type field in Python tests
- Update MCPServerConfigBase JSDoc to reference stdio/http instead of local/remote - Remove explicit type: local from Python E2E tests (omitted type defaults to stdio, matching Go/C# pattern) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 56cee2f commit b8ef5b0

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

nodejs/src/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -924,8 +924,8 @@ interface MCPServerConfigBase {
924924
*/
925925
tools: string[];
926926
/**
927-
* Indicates "remote" or "local" server type.
928-
* If not specified, defaults to "local".
927+
* Indicates the server type: "stdio" for local/subprocess servers, "http"/"sse" for remote servers.
928+
* If not specified, defaults to "stdio".
929929
*/
930930
type?: string;
931931
/**

python/e2e/test_mcp_and_agents.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ async def test_should_accept_mcp_server_configuration_on_session_create(
2525
"""Test that MCP server configuration is accepted on session create"""
2626
mcp_servers: dict[str, MCPServerConfig] = {
2727
"test-server": {
28-
"type": "local",
2928
"command": "echo",
3029
"args": ["hello"],
3130
"tools": ["*"],
@@ -59,7 +58,6 @@ async def test_should_accept_mcp_server_configuration_on_session_resume(
5958
# Resume with MCP servers
6059
mcp_servers: dict[str, MCPServerConfig] = {
6160
"test-server": {
62-
"type": "local",
6361
"command": "echo",
6462
"args": ["hello"],
6563
"tools": ["*"],
@@ -86,7 +84,6 @@ async def test_should_pass_literal_env_values_to_mcp_server_subprocess(
8684
"""Test that env values are passed as literals to MCP server subprocess"""
8785
mcp_servers: dict[str, MCPServerConfig] = {
8886
"env-echo": {
89-
"type": "local",
9087
"command": "node",
9188
"args": [TEST_MCP_SERVER],
9289
"tools": ["*"],
@@ -180,7 +177,6 @@ async def test_should_accept_both_mcp_servers_and_custom_agents(self, ctx: E2ETe
180177
"""Test that both MCP servers and custom agents can be configured together"""
181178
mcp_servers: dict[str, MCPServerConfig] = {
182179
"shared-server": {
183-
"type": "local",
184180
"command": "echo",
185181
"args": ["shared"],
186182
"tools": ["*"],

0 commit comments

Comments
 (0)