Remove Python session event shims

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: stephentoub

python/README.md

@@ -558,9 +558,11 @@ Provide your own function to inspect each request and apply custom logic (sync o
 
 ```python
 from copilot.session import PermissionRequestResult
-from copilot.generated.session_events import PermissionRequest
+from copilot.generated.session_events import PermissionRequestedDataPermissionRequest
 
-def on_permission_request(request: PermissionRequest, invocation: dict) -> PermissionRequestResult:
+def on_permission_request(
+    request: PermissionRequestedDataPermissionRequest, invocation: dict
+) -> PermissionRequestResult:
     # request.kind — what type of operation is being requested:
     #   "shell"       — executing a shell command
     #   "write"       — writing or editing a file
@@ -590,7 +592,9 @@ session = await client.create_session(
 Async handlers are also supported:
 
 ```python
-async def on_permission_request(request: PermissionRequest, invocation: dict) -> PermissionRequestResult:
+async def on_permission_request(
+    request: PermissionRequestedDataPermissionRequest, invocation: dict
+) -> PermissionRequestResult:
     # Simulate an async approval check (e.g., prompting a user over a network)
     await asyncio.sleep(0)
     return PermissionRequestResult(kind="approved")

python/copilot/client.py

@@ -37,7 +37,11 @@
     ServerRpc,
     register_client_session_api_handlers,
 )
-from .generated.session_events import PermissionRequest, SessionEvent, session_event_from_dict
+from .generated.session_events import (
+    PermissionRequestedDataPermissionRequest,
+    SessionEvent,
+    session_event_from_dict,
+)
 from .session import (
     CommandDefinition,
     CopilotSession,
@@ -2635,7 +2639,7 @@ async def _handle_permission_request_v2(self, params: dict) -> dict:
             raise ValueError(f"unknown session {session_id}")
 
         try:
-            perm_request = PermissionRequest.from_dict(permission_request)
+            perm_request = PermissionRequestedDataPermissionRequest.from_dict(permission_request)
             result = await session._handle_permission_request(perm_request)
             if result.kind == "no-result":
                 raise ValueError(NO_RESULT_PERMISSION_V2_ERROR)

python/copilot/generated/session_events.py

@@ -52,8 +52,8 @@
     CommandExecuteData,
     ElicitationRequestedData,
     ExternalToolRequestedData,
-    PermissionRequest,
     PermissionRequestedData,
+    PermissionRequestedDataPermissionRequest,
     SessionErrorData,
     SessionEvent,
     SessionIdleData,
@@ -244,15 +244,15 @@ class PermissionRequestResult:
 
 
 _PermissionHandlerFn = Callable[
-    [PermissionRequest, dict[str, str]],
+    [PermissionRequestedDataPermissionRequest, dict[str, str]],
     PermissionRequestResult | Awaitable[PermissionRequestResult],
 ]
 
 
 class PermissionHandler:
     @staticmethod
     def approve_all(
-        request: PermissionRequest, invocation: dict[str, str]
+        request: PermissionRequestedDataPermissionRequest, invocation: dict[str, str]
     ) -> PermissionRequestResult:
         return PermissionRequestResult(kind="approved")
 
@@ -1621,7 +1621,7 @@ def _register_permission_handler(self, handler: _PermissionHandlerFn | None) ->
             self._permission_handler = handler
 
     async def _handle_permission_request(
-        self, request: PermissionRequest
+        self, request: PermissionRequestedDataPermissionRequest
     ) -> PermissionRequestResult:
         """
         Handle a permission request from the Copilot CLI.

python/copilot/session.py

@@ -6,8 +6,12 @@
 
 import pytest
 
-from copilot.generated.session_events import SessionIdleData, ToolExecutionCompleteData
-from copilot.session import PermissionHandler, PermissionRequest, PermissionRequestResult
+from copilot.generated.session_events import (
+    PermissionRequestedDataPermissionRequest,
+    SessionIdleData,
+    ToolExecutionCompleteData,
+)
+from copilot.session import PermissionHandler, PermissionRequestResult
 
 from .testharness import E2ETestContext
 from .testharness.helper import read_file, write_file
@@ -21,7 +25,7 @@ async def test_should_invoke_permission_handler_for_write_operations(self, ctx:
         permission_requests = []
 
         def on_permission_request(
-            request: PermissionRequest, invocation: dict
+            request: PermissionRequestedDataPermissionRequest, invocation: dict
         ) -> PermissionRequestResult:
             permission_requests.append(request)
             assert invocation["session_id"] == session.session_id
@@ -46,7 +50,7 @@ async def test_should_deny_permission_when_handler_returns_denied(self, ctx: E2E
         """Test denying permissions"""
 
         def on_permission_request(
-            request: PermissionRequest, invocation: dict
+            request: PermissionRequestedDataPermissionRequest, invocation: dict
         ) -> PermissionRequestResult:
             return PermissionRequestResult(kind="denied-interactively-by-user")
 
@@ -158,7 +162,7 @@ async def test_should_handle_async_permission_handler(self, ctx: E2ETestContext)
         permission_requests = []
 
         async def on_permission_request(
-            request: PermissionRequest, invocation: dict
+            request: PermissionRequestedDataPermissionRequest, invocation: dict
         ) -> PermissionRequestResult:
             permission_requests.append(request)
             # Simulate async permission check (e.g., user prompt)
@@ -186,7 +190,7 @@ async def test_should_resume_session_with_permission_handler(self, ctx: E2ETestC
 
         # Resume with permission handler
         def on_permission_request(
-            request: PermissionRequest, invocation: dict
+            request: PermissionRequestedDataPermissionRequest, invocation: dict
         ) -> PermissionRequestResult:
             permission_requests.append(request)
             return PermissionRequestResult(kind="approved")
@@ -206,7 +210,7 @@ async def test_should_handle_permission_handler_errors_gracefully(self, ctx: E2E
         """Test that permission handler errors are handled gracefully"""
 
         def on_permission_request(
-            request: PermissionRequest, invocation: dict
+            request: PermissionRequestedDataPermissionRequest, invocation: dict
         ) -> PermissionRequestResult:
             raise RuntimeError("Handler error")
 
@@ -226,7 +230,7 @@ async def test_should_receive_toolcallid_in_permission_requests(self, ctx: E2ETe
         received_tool_call_id = False
 
         def on_permission_request(
-            request: PermissionRequest, invocation: dict
+            request: PermissionRequestedDataPermissionRequest, invocation: dict
         ) -> PermissionRequestResult:
             nonlocal received_tool_call_id
             if request.tool_call_id: