Make Windows test cleanup soft-fail to fully tolerate CLI 1.0.40-1 SQLite race

The previous tightening (30s rmDir retry; suppress(OSError) for unlink in central context.py) was not enough on Windows: the @github/copilot 1.0.40-1 CLI keeps the SQLite session-store.db handle open longer than 30 seconds in some cases, and three additional multi-client test files have their own configure_for_test methods with the same unlink-without-suppression pattern.

- python/e2e/test_commands.py, test_multi_client.py, test_ui_elicitation_multi_client.py: wrap item.unlink(missing_ok=True) in contextlib.suppress(OSError), matching the change in testharness/context.py

- nodejs/test/e2e/harness/sdkTestContext.ts: rmDir now warns instead of throwing if the temp dir cannot be removed after the 30s retry budget — temp dirs are reclaimed by the OS / GitHub Actions runner anyway, so a stale temp dir should not fail the entire test suite when 245/254 tests passed

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: stephentoub

nodejs/test/e2e/harness/sdkTestContext.ts

@@ -11,7 +11,7 @@ import { fileURLToPath } from "url";
 import { afterAll, afterEach, beforeEach, onTestFailed, TestContext } from "vitest";
 import { CopilotClient, CopilotClientOptions } from "../../../src";
 import { CapiProxy } from "./CapiProxy";
-import { retry } from "./sdkTestHelper";
+import { retry, formatError } from "./sdkTestHelper";
 
 export const isCI = process.env.GITHUB_ACTIONS === "true";
 
@@ -111,8 +111,17 @@ function getTrafficCapturePath(testContext: TestContext): string {
     return join(SNAPSHOTS_DIR, testFileName, `${taskNameAsFilename}.yaml`);
 }
 
-function rmDir(message: string, path: string): Promise<void> {
-    // Use longer retries (30s total) to tolerate Windows holding SQLite
-    // session-store.db open briefly after the CLI subprocess exits.
-    return retry(message, () => rm(path, { recursive: true, force: true }), 30, 1000);
+async function rmDir(message: string, path: string): Promise<void> {
+    // Use longer retries to tolerate Windows holding SQLite session-store.db
+    // open briefly after the CLI subprocess exits. If the temp dir still can't
+    // be removed (e.g. CLI background writer racing with cleanup), warn and
+    // continue rather than failing the whole test run — the OS / CI runner
+    // will reclaim the temp dir on shutdown.
+    try {
+        await retry(message, () => rm(path, { recursive: true, force: true }), 30, 1000);
+    } catch (error) {
+        console.warn(
+            `WARN: ${message} failed; leaving temp dir for OS cleanup: ${formatError(error)}`
+        );
+    }
 }

python/e2e/test_commands.py

@@ -7,6 +7,7 @@
 """
 
 import asyncio
+import contextlib
 import os
 import shutil
 import tempfile
@@ -106,7 +107,8 @@ async def configure_for_test(self, test_file: str, test_name: str):
                 if item.is_dir():
                     shutil.rmtree(item, ignore_errors=True)
                 else:
-                    item.unlink(missing_ok=True)
+                    with contextlib.suppress(OSError):
+                        item.unlink(missing_ok=True)
 
     def _get_env(self) -> dict:
         env = os.environ.copy()

python/e2e/test_multi_client.py

@@ -5,6 +5,7 @@
 """
 
 import asyncio
+import contextlib
 import os
 import shutil
 import tempfile
@@ -110,19 +111,17 @@ async def configure_for_test(self, test_file: str, test_name: str):
         if self._proxy:
             await self._proxy.configure(abs_snapshot_path, self.work_dir)
 
-        # Clear temp directories between tests
+        # Clear temp directories between tests; tolerate Windows holding the
+        # SQLite session-store.db open briefly after the CLI subprocess exits.
         from pathlib import Path
 
-        for item in Path(self.home_dir).iterdir():
-            if item.is_dir():
-                shutil.rmtree(item, ignore_errors=True)
-            else:
-                item.unlink(missing_ok=True)
-        for item in Path(self.work_dir).iterdir():
-            if item.is_dir():
-                shutil.rmtree(item, ignore_errors=True)
-            else:
-                item.unlink(missing_ok=True)
+        for base_dir in (self.home_dir, self.work_dir):
+            for item in Path(base_dir).iterdir():
+                if item.is_dir():
+                    shutil.rmtree(item, ignore_errors=True)
+                else:
+                    with contextlib.suppress(OSError):
+                        item.unlink(missing_ok=True)
 
     def get_env(self) -> dict:
         env = os.environ.copy()

python/e2e/test_ui_elicitation_multi_client.py

@@ -8,6 +8,7 @@
 """
 
 import asyncio
+import contextlib
 import os
 import shutil
 import tempfile
@@ -113,7 +114,8 @@ async def configure_for_test(self, test_file: str, test_name: str):
                 if item.is_dir():
                     shutil.rmtree(item, ignore_errors=True)
                 else:
-                    item.unlink(missing_ok=True)
+                    with contextlib.suppress(OSError):
+                        item.unlink(missing_ok=True)
 
     def _get_env(self) -> dict:
         env = os.environ.copy()