Skip to content

Commit d5c6fd5

Browse files
stephentoubCopilot
andcommitted
chore(nodejs): use 0.0.0-dev version sentinel for consistency
The Node SDK committed a real-looking version (0.1.8) in package.json and reset to 0.1.0 in the package script, unlike the .NET and Rust SDKs which use a 0.0.0-dev sentinel. CI injects the real version at publish via set-version.js, so the committed value should be an unmistakable dev placeholder rather than a stale real version. Align package.json, the package script, set-version.js default, and the package-lock.json files (including nodejs/samples) to 0.0.0-dev. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 9dd1c2e commit d5c6fd5

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

nodejs/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"type": "git",
55
"url": "https://github.com/github/copilot-sdk.git"
66
},
7-
"version": "0.1.8",
7+
"version": "0.0.0-dev",
88
"description": "TypeScript SDK for programmatic control of GitHub Copilot CLI via JSON-RPC",
99
"main": "./dist/cjs/index.js",
1010
"types": "./dist/index.d.ts",
@@ -44,7 +44,7 @@
4444
"generate": "cd ../scripts/codegen && npm run generate",
4545
"update:protocol-version": "tsx scripts/update-protocol-version.ts",
4646
"prepublishOnly": "npm run build",
47-
"package": "npm run clean && npm run build && node scripts/set-version.js && npm pack && npm version 0.1.0 --no-git-tag-version --allow-same-version"
47+
"package": "npm run clean && npm run build && node scripts/set-version.js && npm pack && npm version 0.0.0-dev --no-git-tag-version --allow-same-version"
4848
},
4949
"keywords": [
5050
"github",

nodejs/samples/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/scripts/set-version.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { readFileSync, writeFileSync } from "fs";
33
import { dirname, join } from "path";
44
import { fileURLToPath } from "url";
55

6-
const version = process.env.VERSION || "0.1.0-dev";
6+
const version = process.env.VERSION || "0.0.0-dev";
77
const packageJsonPath = join(dirname(fileURLToPath(import.meta.url)), "..", "package.json");
88

99
const packageJson = JSON.parse(readFileSync(packageJsonPath, "utf8"));

0 commit comments

Comments
 (0)